Opened 3 years ago
Closed 3 years ago
#24843 closed defect (fixed)
Issue with padic printing
Reported by:  caruso  Owned by:  

Priority:  major  Milestone:  sage8.2 
Component:  padics  Keywords:  printing padics, padicIMA 
Cc:  roed, saraedum  Merged in:  
Authors:  Xavier Caruso  Reviewers:  David Roe 
Report Upstream:  N/A  Work issues:  
Branch:  a736db8 (Commits, GitHub, GitLab)  Commit:  a736db876e9794af1b7e43bd1f737d6e04ab244b 
Dependencies:  #23450, #23218  Stopgaps: 
Description
sage: R = Zp(2, print_mode='digits', show_prec=True) sage: R(0,10) ...0000000000^10)
Change History (25)
comment:1 Changed 3 years ago by
 Branch set to u/caruso/padic_printing
comment:2 Changed 3 years ago by
 Commit set to 5bf6d9df6f188d8e0b57a0e78b4ac93f133d844d
 Status changed from new to needs_review
comment:3 Changed 3 years ago by
 Branch changed from u/caruso/padic_printing to u/roed/padic_printing
comment:4 Changed 3 years ago by
 Commit changed from 5bf6d9df6f188d8e0b57a0e78b4ac93f133d844d to eb99ef331335fe31df53b46f5e7ba0d9299a00bf
 Reviewers set to David Roe
If Xavier is happy with my changes, positive review.
New commits:
eb99ef3  Fix some more doctest output, a few minor changes and comments

comment:5 Changed 3 years ago by
I am (as soon as the patchbot does not complain).
comment:6 Changed 3 years ago by
 Commit changed from eb99ef331335fe31df53b46f5e7ba0d9299a00bf to c6c0cd8de694c5f21299f6ef54b2dc5c88ec44d8
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
8b239f4  trac 23450 details of doc

93d4e32  Merge branch 'public/23450' in 8.1

14f591c  fixing 2 doctests

cf85a34  Merge branch 'public/23450' of ssh://trac.sagemath.org/sage into t/23450/padic_smith

7ad838a  Remove _get_matrix_class that was inadvertently added in a merge

b5863a1  Add newline back in from fix to matrix_space.py

777f494  Remove the tracks_precision method and update the padic smith form to be able to deal with lattice elements

d78a1d5  Add exact parameter to _matrix_smith_form, fix precision behavior and allow integral=True for nonpadic matrices

d9ad1e5  Merge branch 't/23450/padic_smith' into t/24843/padic_printing

c6c0cd8  Fix doctest in matrix2 due to changes in printing

comment:7 Changed 3 years ago by
 Dependencies set to #23450
comment:8 Changed 3 years ago by
 Commit changed from c6c0cd8de694c5f21299f6ef54b2dc5c88ec44d8 to ba0ea8cc66596b1a0b0ee8ac144ee1784105be2e
Branch pushed to git repo; I updated commit sha1. New commits:
ba0ea8c  Fix doctest in Explicit Methods in Number Theory

comment:9 Changed 3 years ago by
 Keywords padicIMA added
comment:10 Changed 3 years ago by
 Commit changed from ba0ea8cc66596b1a0b0ee8ac144ee1784105be2e to debf1fc2d9240d7a9a5cec8d66f269102b219f6c
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
debf1fc  Commit to make different from develop

comment:11 Changed 3 years ago by
 Branch changed from u/roed/padic_printing to u/roed/padic_prints
comment:12 Changed 3 years ago by
 Commit changed from debf1fc2d9240d7a9a5cec8d66f269102b219f6c to c3af1bd12b4861d22d29c69bd007647ebb76c737
Branch pushed to git repo; I updated commit sha1. New commits:
c3af1bd  Merge branch 'u/roed/padic_prints' of git://trac.sagemath.org/sage into t/24843/padic_prints

comment:13 Changed 3 years ago by
 Branch changed from u/roed/padic_prints to u/caruso/padic_prints
comment:14 Changed 3 years ago by
 Commit changed from c3af1bd12b4861d22d29c69bd007647ebb76c737 to 74f7fb9d7e72342660e071003cf8ea4758a88870
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
1453379  creduce after coercion from CA to its fraction field

5ffb263  replace creduce by normalize

7e842e3  Avoid to call two times cremove

618c61e  More reduce

b50388a  Working on fixing bugs in nonCR types

0145c56  Merge branch 'u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/general_extensions

8d27ed7  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

8654e79  Make several methods work (or raise a NotImplementedError) for extensions

e156f7f  Write a test suite for the shifting operator

74f7fb9  Merge branch 't/23218/ramified_extensions_of_general_p_adic_rings_and_fields' into t/24843/padic_prints

comment:15 Changed 3 years ago by
 Dependencies changed from #23450 to #23450, #23218
I've merged this ticket with #23218 in order to be sure that they are not in conflit.
comment:16 Changed 3 years ago by
 Commit changed from 74f7fb9d7e72342660e071003cf8ea4758a88870 to 3104af8e046ae8abe67aa06d819ad7c0c8e518ca
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
cabb63e  Merge branch 'u/caruso/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision

4fed21f  Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

aacb4c2  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

0ea13c0  Fix two bugs: one in expansion, one in cshift

22840e5  Prevent _test_log to compute log(0)

87f4c43  Always creduce after cremove

b1a3236  Remove unwanted print statements

31ae67d  Merge branch 't/23218/ramified_extensions_of_general_p_adic_rings_and_fields' into t/24843/padic_prints

9bce799  Fix docbuild problem

3104af8  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/24843/padic_prints

comment:17 Changed 3 years ago by
 Branch changed from u/caruso/padic_prints to u/roed/padic_prints
comment:18 Changed 3 years ago by
 Commit changed from 3104af8e046ae8abe67aa06d819ad7c0c8e518ca to fcd4672c887a4a5efa8435470464f8d21ea24608
Branch pushed to git repo; I updated commit sha1. New commits:
0e6628d  Fix conversion from QqFP to QqCR

8576c59  Change construction functors for padics, making pushouts work in towers

b45a21e  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

2d1a5c7  allow extension() method to accept implementation and prec arguments

bfe8ac7  Merge branch 't/23218/ramified_extensions_of_general_p_adic_rings_and_fields' into t/24843/padic_prints

b6cbd1d  Update polynomial printing, fix doctests

fcd4672  Fix a couple more doctest errors

comment:19 Changed 3 years ago by
 Commit changed from fcd4672c887a4a5efa8435470464f8d21ea24608 to b8a847dd7d97a366b632bebc8ac72ea47394acd1
comment:20 Changed 3 years ago by
 Branch changed from u/roed/padic_prints to u/caruso/padic_prints
comment:21 Changed 3 years ago by
 Branch changed from u/caruso/padic_prints to u/roed/padic_prints
comment:22 Changed 3 years ago by
 Commit changed from b8a847dd7d97a366b632bebc8ac72ea47394acd1 to a736db876e9794af1b7e43bd1f737d6e04ab244b
Branch pushed to git repo; I updated commit sha1. New commits:
a736db8  Fixing doctests due to changes in polynomial printing

comment:23 Changed 3 years ago by
All tests pass. I'm happy with this ticket, if Xavier approves of my changes to polynomial printing.
comment:24 Changed 3 years ago by
 Status changed from needs_review to positive_review
I do.
As for #23218, the patchbot reports failures but I think that they are not related to this ticket.
I give a positive review to this ticket. Feel free to revert this if you disagree.
comment:25 Changed 3 years ago by
 Branch changed from u/roed/padic_prints to a736db876e9794af1b7e43bd1f737d6e04ab244b
 Resolution set to fixed
 Status changed from positive_review to closed
I fixed this issue and addressed at the same time #23234.
I've extended the set of possible values allowed for the keyword
show_prec
: it can now eithernone
(no precision is printed),bigoh
ordots
. A boolean is still possible:False
always meansnone
whileTrue
meansbigoh
ordots
depending on the printing mode.New commits:
New options for show_prec: 'none', 'bigoh' and 'dots'