Opened 4 years ago

Closed 4 years ago

#24840 closed defect (fixed)

gambit does not install

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.2
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: b3bcbc1 (Commits, GitHub, GitLab) Commit: b3bcbc1570cfad10272f9a47595327e8361f61d9
Dependencies: Stopgaps:

Status badges

Change History (9)

comment:1 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Report Upstream changed from N/A to Reported upstream. No feedback yet.
  • Summary changed from Use pip to install gambit Python interface to gambit does not install

comment:2 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/gambit_does_not_install

comment:3 Changed 4 years ago by jdemeyer

  • Commit set to 16e377ea7e30b5b67177e053978b890d508ee8e0

New commits:

16e377eFix build of gambit

comment:4 Changed 4 years ago by jdemeyer

  • Status changed from new to needs_review

comment:5 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 4 years ago by git

  • Commit changed from 16e377ea7e30b5b67177e053978b890d508ee8e0 to b3bcbc1570cfad10272f9a47595327e8361f61d9
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

b3bcbc1Fix build of gambit

comment:8 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

I made an upstream pull request and changed the comment in spkg-install.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/gambit_does_not_install to b3bcbc1570cfad10272f9a47595327e8361f61d9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.