Opened 4 years ago

Closed 4 years ago

#24829 closed defect (fixed)

zero_matrix() should pass the correct zero

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.2
Component: linear algebra Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 17cd4fb (Commits, GitHub, GitLab) Commit: 17cd4fb1caba6ade402ad542abbd14c05a20ea09
Dependencies: Stopgaps:

Status badges

Description

The method zero_matrix() passes coerce=False to the matrix class constructor. If so, it should pass the correct zero of the base ring, not int(0).

This bug causes segfaults in #24742 because the coerce flag is honored in more cases.

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/zero_matrix___should_pass_the_correct_zero

comment:2 Changed 4 years ago by jdemeyer

  • Cc tscrim added
  • Commit set to 17cd4fb1caba6ade402ad542abbd14c05a20ea09
  • Status changed from new to needs_review

New commits:

17cd4fbzero_matrix() should pass the correct zero

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/zero_matrix___should_pass_the_correct_zero to 17cd4fb1caba6ade402ad542abbd14c05a20ea09
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.