Missing dependencies cause sagetex to fail to build when SAGE_CHECK=yes

[Konrad127123]

sagetex can fail to build if SAGE_CHECK=yes due to missing dependencies

To reproduce: make distclean && make sagetex

(An earlier version of this bug report dealt with issues building cypari and pycrypto if SAGE_CHECK=yes. These were fixed in #25813 and #25844, respectively.)

[Konrad127123]

This patch adds the minimal list of missing packages needed to fix things. (Tested with make distclean && make package_name )

[Konrad127123]

New commits:

​e00134b

Fix dependencies for cypari, pycrypto and sagetex, so that they build successfully when SAGE_CHECK=yes.

[jdemeyer]

pycrypto works for me without your patch.

[jdemeyer]

And I consider the dependency of cypari on six an upstream bug (it doesn't really need six) which is fixed now.

[jdemeyer]

scandir is actually a dependency of pathlib2, I fixed that in #24996.

[Konrad127123]

Replying to jdemeyer:

pycrypto works for me without your patch.

Do you have system mpir or gmp installed? If I install the libgmp-dev package (on Debian Unstable)

make distclean  && make pycrypto

passes. If I don't have it installed then testing fails with:

ERROR: test_negative_number_roundtrip_mpzToLongObj_longObjToMPZ (Crypto.SelfTest.Util.test_number.MiscTests)
Test that mpzToLongObj and longObjToMPZ (internal functions) roundtrip negative numbers correctly.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/sage/build_experiments/sage-8.1/local/lib/python2.7/site-packages/Crypto/SelfTest/Util/test_number.py", line 283, in test_negative_number_round
trip_mpzToLongObj_longObjToMPZ
    k = number._fastmath.rsa_construct(n, e)
AttributeError: 'NoneType' object has no attribute 'rsa_construct'

----------------------------------------------------------------------
Ran 1033 tests in 48.713s

FAILED (errors=1)
Traceback (most recent call last):
  File "setup.py", line 456, in <module>
    core.setup(**kw)
  File "/home/sage/build_experiments/sage-8.1/local/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/home/sage/build_experiments/sage-8.1/local/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/home/sage/build_experiments/sage-8.1/local/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "setup.py", line 336, in run
    SelfTest.run(module=moduleObj, verbosity=self.verbose, stream=sys.stdout, config=self.config)
  File "/home/sage/build_experiments/sage-8.1/local/lib/python2.7/site-packages/Crypto/SelfTest/__init__.py", line 74, in run
    raise SelfTestError("Self-test failed", result)
Crypto.SelfTest.SelfTestError: ('Self-test failed', <unittest.runner.TextTestResult run=1033 errors=1 failures=0>)
Error: PyCrypto failed to pass its test suite.

With my patch, testing succeeds for me even if system libgmp-dev is not installed.

[jdemeyer]

Replying to Konrad127123:

Replying to jdemeyer:

pycrypto works for me without your patch.

Do you have system mpir or gmp installed?

You are right. pycrypto does require GMP/MPIR. But since it links against it, it should be a real dependency (on the left of the | symbol) instead of an order-only dependency (on the right of the | symbol).

[jdemeyer]

I would prefer to revert the change to the dependencies of cypari. It will be fixed in the next release.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​88d2d36

Fix cypari doctest and pycrypto dependencies.

[Konrad127123]

How's the above for a solution for cypari and pycrypto?

In the latest beta sagetex (even with my patch) is failing with

************************************************************************
It seems that you are attempting to run Sage from an unpacked source
tarball, but you have not compiled it yet (or maybe the build has not
finished). You should run `make` in the Sage root directory first.
If you did not intend to build Sage from source, you should download
a binary tarball instead. Read README.txt for more information.
************************************************************************

I don't think that happened with 8.2.beta.6 and I haven't tried to find the cause yet. (As an aside, neither scandir nor pathlib2 get pulled in as dependencies when doing make distclean && make sagetex.)

[jdemeyer]

Replying to Konrad127123:

How's the above for a solution for cypari and pycrypto?

In the latest beta sagetex (even with my patch) is failing with

************************************************************************
It seems that you are attempting to run Sage from an unpacked source
tarball, but you have not compiled it yet (or maybe the build has not
finished). You should run `make` in the Sage root directory first.
If you did not intend to build Sage from source, you should download
a binary tarball instead. Read README.txt for more information.
************************************************************************

Yes, that is #24995.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​2031aef

Remove unneeded dependency.

[Konrad127123]

Ready to review again, I think.

[jdemeyer]

Looks good to me on first sight. I still need to test it though.

[Konrad127123]

Have you had a chance to test it yet? Since it's a build issue, it would be nice to get this into 8.2.

[slelievre]

We might no longer need pycrypto, see #25844 (Remove package pycrypto).

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​a1bf82e	matplotlib should have a runtime dependency on kiwisolver
​93a97e9	Add missing dependencies to make sagtex build when SAGE_CHECK=yes

[jhpalmieri]

Another SageTeX issue: #26343.

[Konrad127123]

Dependencies updated for 8.4rc0:

Doing make distclean && make sagetex fails unless kiwisolver, sympy, elliptic_curves and jmol are installed.

kiwisolver should really get pulled in by matplotlib, not sagetex, so I've added it to matplotlib's runtime dependencies (this got missed in #25702) and added to the rest to sagetex.

I tested with 8.4rc0 and confirmed that sagetex now builds with SAGE_CHECK=yes. I've also confirmed that adding any combination of three of the dependencies is not sufficient.

[Konrad127123]

Sorry, should have set to needs_review above

[Konrad127123]

I tested with 8.4rc0 and confirmed that sagetex now builds with SAGE_CHECK=yes. I've also confirmed that adding any combination of three of the dependencies is not sufficient.

I have confirmed that this is still the case with 8.5beta0.

[Konrad127123]

Patch still works for 8.5beta1 and is still the minimum set of dependencies needed.

[jhpalmieri]

Looks okay to me.