py3: minor fixes in sage.interfaces

[embray]

Minor Python 3 fixes to different modules in sage.interfaces. These were all small and discrete enough to be combined--most are moving open() calls to with statements to prevent ResourceWarnings in tests.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​afb7643	Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
​2181b3e	py3: additional minor str/bytes fixes to the sage.interfaces framework
​00716a4	py3: minor ResourceWarning fix in sage.interfaces.gap
​00079d3	py3: minor ResourceWarning fixes in sage.interfaces.psage
​6469a9e	py3: minor stylistic fix and map->list comprehension fixes in sage.interfaces.qepcad
​9becd3b	py3: minor ResourceWarning fix in sage.interfaces.quit

[vdelecroix]

Wouldn't it be useful to check that files are properly closed? At least the module psutil can be used to list the opened ones.

[mantepse]

How come clicking on the branch field in this ticket and looking at the diff tells me that gap.py and qepcad.py were deleted?

[embray]

I don't know. Weird. I'll try rebasing.

[git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

​83bd735	Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
​9803d00	py3: additional minor str/bytes fixes to the sage.interfaces framework
​05d3a0b	py3: minor ResourceWarning fix in sage.interfaces.gap
​2f741c2	py3: minor ResourceWarning fixes in sage.interfaces.psage
​33a326a	py3: minor stylistic fix and map->list comprehension fixes in sage.interfaces.qepcad
​f9fda19	py3: minor ResourceWarning fix in sage.interfaces.quit

[embray]

Should be better now. Might be the old merge preview was corrupted somehow.

[vdelecroix]

merge conflicts

[embray]

*sigh* I literally rebased this not 24 hours ago...

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​66bfe0e	Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
​b0b8633	py3: additional minor str/bytes fixes to the sage.interfaces framework
​6be80e0	py3: minor ResourceWarning fix in sage.interfaces.gap
​a69c82f	py3: minor ResourceWarning fixes in sage.interfaces.psage
​620d35e	py3: minor stylistic fix and map->list comprehension fixes in sage.interfaces.qepcad
​1c06fae	py3: minor ResourceWarning fix in sage.interfaces.quit

[vdelecroix]

Sorry for this double rebasing! I really hope that we will switch to a smoother integration process for tickets!

[embray]

Not your (or anyone else's) fault. Actually this is the sort of case that would not as easily be fixed by a smoother integration process--it was just an example of one ticket being merged first that this one conflicted with, and that's perfectly normal and sometimes unavoidable (though cases like that will be caught more quickly with more regular merging...) I was just needlessly exasperated!