#24783 closed defect (fixed)

py3: minor fixes in sage.interfaces

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.3
Component: python3 Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 1c06fae (Commits) Commit: 1c06fae98a995b7126b7dd4580108c60374e0a4e
Dependencies: Stopgaps:

Description

Minor Python 3 fixes to different modules in sage.interfaces. These were all small and discrete enough to be combined--most are moving open() calls to with statements to prevent ResourceWarnings in tests.

Change History (15)

comment:1 Changed 22 months ago by git

  • Commit changed from dce624ba78365195d8593f287c2f4000519f6706 to 9becd3b5bc927b886781e1001d78d99f442f42eb

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

afb7643Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
2181b3epy3: additional minor str/bytes fixes to the sage.interfaces framework
00716a4py3: minor ResourceWarning fix in sage.interfaces.gap
00079d3py3: minor ResourceWarning fixes in sage.interfaces.psage
6469a9epy3: minor stylistic fix and map->list comprehension fixes in sage.interfaces.qepcad
9becd3bpy3: minor ResourceWarning fix in sage.interfaces.quit

comment:2 Changed 22 months ago by embray

  • Status changed from new to needs_review

comment:3 Changed 20 months ago by embray

  • Milestone changed from sage-8.2 to sage-8.3

comment:4 Changed 19 months ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Wouldn't it be useful to check that files are properly closed? At least the module psutil can be used to list the opened ones.

comment:5 Changed 19 months ago by mantepse

How come clicking on the branch field in this ticket and looking at the diff tells me that gap.py and qepcad.py were deleted?

comment:6 Changed 19 months ago by embray

I don't know. Weird. I'll try rebasing.

comment:7 Changed 19 months ago by git

  • Commit changed from 9becd3b5bc927b886781e1001d78d99f442f42eb to f9fda199860fd6a33852166ebbccea169d53b76b
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

83bd735Update SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
9803d00py3: additional minor str/bytes fixes to the sage.interfaces framework
05d3a0bpy3: minor ResourceWarning fix in sage.interfaces.gap
2f741c2py3: minor ResourceWarning fixes in sage.interfaces.psage
33a326apy3: minor stylistic fix and map->list comprehension fixes in sage.interfaces.qepcad
f9fda19py3: minor ResourceWarning fix in sage.interfaces.quit

comment:8 Changed 19 months ago by embray

Should be better now. Might be the old merge preview was corrupted somehow.

comment:9 Changed 19 months ago by vdelecroix

  • Status changed from needs_review to needs_work

merge conflicts

comment:10 Changed 19 months ago by embray

*sigh* I literally rebased this not 24 hours ago...

comment:11 Changed 19 months ago by git

  • Commit changed from f9fda199860fd6a33852166ebbccea169d53b76b to 1c06fae98a995b7126b7dd4580108c60374e0a4e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

66bfe0eUpdate SagePtyProcess and the Maxima and GAP pexpect interfaces to handle bytes roughly appropriately on Python 3
b0b8633py3: additional minor str/bytes fixes to the sage.interfaces framework
6be80e0py3: minor ResourceWarning fix in sage.interfaces.gap
a69c82fpy3: minor ResourceWarning fixes in sage.interfaces.psage
620d35epy3: minor stylistic fix and map->list comprehension fixes in sage.interfaces.qepcad
1c06faepy3: minor ResourceWarning fix in sage.interfaces.quit

comment:12 Changed 19 months ago by embray

  • Status changed from needs_work to needs_review

comment:13 Changed 19 months ago by vdelecroix

  • Status changed from needs_review to positive_review

Sorry for this double rebasing! I really hope that we will switch to a smoother integration process for tickets!

comment:14 Changed 19 months ago by embray

Not your (or anyone else's) fault. Actually this is the sort of case that would not as easily be fixed by a smoother integration process--it was just an example of one ticket being merged first that this one conflicted with, and that's perfectly normal and sometimes unavoidable (though cases like that will be caught more quickly with more regular merging...) I was just needlessly exasperated!

comment:15 Changed 19 months ago by vbraun

  • Branch changed from u/embray/python3/sage-interfacs/misc to 1c06fae98a995b7126b7dd4580108c60374e0a4e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.