Opened 4 years ago

Closed 3 years ago

#24782 closed enhancement (fixed)

add parameter solver to method chromatic_number

Reported by: dcoudert Owned by:
Priority: minor Milestone: sage-8.3
Component: graph theory Keywords:
Cc: jmantysalo Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9266636 (Commits, GitHub, GitLab) Commit: 926663631d2d5bc1b9cef3627670b6bf17ea05be
Dependencies: Stopgaps:

Status badges

Description

When algorithm='MILP', we must be able to select the LP solver. This is not the case yet.

Change History (10)

comment:1 Changed 4 years ago by dcoudert

  • Branch set to public/24782_chromatic_number
  • Commit set to 820526dd3b737790cca83f08d2f9f290b742f3b9
  • Status changed from new to needs_review

No need to add specific extra tests since the solver parameter is tested in method vertex_coloring.


New commits:

820526dtrac #24782: add parameter solver to chromatic_number

comment:2 Changed 4 years ago by git

  • Commit changed from 820526dd3b737790cca83f08d2f9f290b742f3b9 to 626660e14cd92728a4a8af5cd2bc6cbfe161d097

Branch pushed to git repo; I updated commit sha1. New commits:

626660etrac #24782: Merged with 8.2.beta8

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Nitpick, but you can just use

-:meth:`solve <sage.numerical.mip.MixedIntegerLinearProgram.solve>`
+:meth:`~sage.numerical.mip.MixedIntegerLinearProgram.solve`
-:class:`MixedIntegerLinearProgram <sage.numerical.mip.MixedIntegerLinearProgram>`
+:class:`~sage.numerical.mip.MixedIntegerLinearProgram`

Otherwise LGTM. You can set a positive review once fixed or if you want to just ignore.

comment:4 Changed 4 years ago by jmantysalo

A sidenote: Should we test for a combination of solver != None and algorithm != 'MILP'? At least it is not important, so don't bother with it on this ticket.

comment:5 Changed 4 years ago by git

  • Commit changed from 626660e14cd92728a4a8af5cd2bc6cbfe161d097 to dcab8362a91d1204eb48e49d8550542decb3ef0e

Branch pushed to git repo; I updated commit sha1. New commits:

dcab836trac #24782: improve links in documentation

comment:6 Changed 4 years ago by dcoudert

I changed the links. However, I don't want to test the combination algorithm / solver. It's not done elsewhere (in general) and we can ignore the solver if we use another algorithm.

comment:7 Changed 3 years ago by git

  • Commit changed from dcab8362a91d1204eb48e49d8550542decb3ef0e to 926663631d2d5bc1b9cef3627670b6bf17ea05be

Branch pushed to git repo; I updated commit sha1. New commits:

9266636trac #24782: Merged with 8.3.beta0

comment:8 Changed 3 years ago by dcoudert

  • Milestone changed from sage-8.2 to sage-8.3

comment:9 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

Sorry, forgot about this. LGTM.

comment:10 Changed 3 years ago by vbraun

  • Branch changed from public/24782_chromatic_number to 926663631d2d5bc1b9cef3627670b6bf17ea05be
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.