#24774 closed enhancement (fixed)

py3: get rid of calls to unicode in inventory builder

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: python3 Keywords:
Cc: jdemeyer, fbissey, embray Merged in:
Authors: Erik Bray Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: a81d4fb (Commits) Commit: a81d4fb4c7b53485cfa6e4597bedede9991f2450
Dependencies: Stopgaps:

Description

little step towards being able to make the doc with python3

Change History (8)

comment:1 Changed 13 months ago by chapoton

  • Branch set to u/chapoton/24774
  • Commit set to 72e63c9f27bfc87c478b10088e7c4e3aef04e3a7
  • Status changed from new to needs_review

New commits:

72e63c9py3: get rid of 2 calls to unicode in inventory_builder

comment:2 Changed 13 months ago by embray

  • Branch changed from u/chapoton/24774 to u/embray/python3/ticket-24774
  • Commit changed from 72e63c9f27bfc87c478b10088e7c4e3aef04e3a7 to a81d4fb4c7b53485cfa6e4597bedede9991f2450

Funny, I just fixed this as well nearly simultaneously. But unfortunately I don't think the above is the correct fix. Here we actually wanted unicode(...) even on Python 2 in case there was unicode text in those objects. str_to_bytes isn't necessary here either. Here's my fix.


New commits:

a81d4fbpy3: fix use of unicode in sage_setup.docbuild.ext.inventory_builder

comment:3 Changed 13 months ago by chapoton

indeed, looks better

comment:4 Changed 13 months ago by embray

Not that non-ASCII text is even likely to occur in either of those cases, but it looks like it was at least intended as a possibility...

comment:5 Changed 13 months ago by chapoton

so, can we now move on here ?

comment:6 Changed 13 months ago by embray

Since I replaced your branch with mine you're welcome to look at it and give it a review.

comment:7 Changed 13 months ago by chapoton

  • Authors changed from Frédéric Chapoton to Erik Bray
  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:8 Changed 13 months ago by vbraun

  • Branch changed from u/embray/python3/ticket-24774 to a81d4fb4c7b53485cfa6e4597bedede9991f2450
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.