Opened 4 years ago

Closed 4 years ago

#24756 closed defect (fixed)

Don't run pcre test suite on Cygwin

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.2
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: e4e85e8 (Commits, GitHub, GitLab) Commit: e4e85e80c43dc12f805ef3760185bd05ba4e0afc
Dependencies: Stopgaps:

Status badges

Change History (9)

comment:1 Changed 4 years ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/cygwin/pcre/check
  • Commit set to 1689baa327a29d56369fccb79a6496841cfa951f
  • Status changed from new to needs_review

New commits:

1689baaFixes https://trac.sagemath.org/ticket/24756

comment:2 Changed 4 years ago by jdemeyer

Just a question: do you build R on Cygwin? I ask because R needs PCRE and a broken PCRE might yield a broken R. This is how we found out about the PCRE issues on Solaris.

Or maybe only specific parts of PCRE are broken that are not used by R on Cygwin.

comment:3 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_info

comment:4 follow-up: Changed 4 years ago by embray

  • Status changed from needs_info to needs_review

I don't know--there's like one test for PCRE that fails but I haven't looked into it. The full tests for R have never passed on Cygwin either; see #22866. But I'll run them again to see if any of them are "obviously" regexp related (I'd be surprised).

I'd certainly like to address #22866 but it's low priority short of actual bug reports from users (and I don't think many people are installing Sage in order to use R on Windows...)

comment:5 in reply to: ↑ 4 Changed 4 years ago by jdemeyer

Replying to embray:

I don't know--there's like one test for PCRE that fails but I haven't looked into it. The full tests for R have never passed on Cygwin either

On Solaris, even the build of R fails with the broken PCRE. So it seems that the Cygwin problem is not that severe.

The only thing that I'm missing in this branch is a comment saying that we don't run the testsuite on Cygwin because it fails always in a way which doesn't seem to affect other packages. positive review if you add that.

comment:6 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to needs_work

comment:7 Changed 4 years ago by git

  • Commit changed from 1689baa327a29d56369fccb79a6496841cfa951f to e4e85e80c43dc12f805ef3760185bd05ba4e0afc

Branch pushed to git repo; I updated commit sha1. New commits:

e4e85e8Comment

comment:8 Changed 4 years ago by embray

  • Status changed from needs_work to positive_review

I think the additional comment is mostly superfluous since there's already a link to the original ticket, which could also be updated with a note about this. But I don't object.


New commits:

e4e85e8Comment

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/embray/cygwin/pcre/check to e4e85e80c43dc12f805ef3760185bd05ba4e0afc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.