Opened 13 years ago

Closed 13 years ago

#2475 closed defect (fixed)

[with patch; with positive review] doctest -- get coverage of modular/dims.py up to 100%

Reported by: was Owned by: was
Priority: major Milestone: sage-2.10.4
Component: modular forms Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

When I started this (sage-2.10.3):

dims.py
SCORE dims.py: 11% (6 of 54)

Attachments (6)

sage-2475-part1.patch (8.3 KB) - added by was 13 years ago.
SCORE dims.py: 31% (17 of 54); and I fixed a serious bug in p-new subspace!
sage-2475-part2_of_2.patch (27.0 KB) - added by was 13 years ago.
this brings coverage to 100% and fixes a serious bug.
sage-2475-part3-latex.patch (8.2 KB) - added by was 13 years ago.
sage-2475-part4-touch-ups.patch (5.5 KB) - added by craigcitro 13 years ago.
trac_2475-part5.patch (657 bytes) - added by mabshoff 13 years ago.
sage-2475-part6.patch (672 bytes) - added by craigcitro 13 years ago.

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by was

SCORE dims.py: 31% (17 of 54); and I fixed a serious bug in p-new subspace!

Changed 13 years ago by was

this brings coverage to 100% and fixes a serious bug.

comment:1 Changed 13 years ago by was

  • Milestone changed from sage-2.11 to sage-2.10.4
  • Summary changed from doctest -- get coverage of modular/dims.py up to 100% to [with patch; needs review] doctest -- get coverage of modular/dims.py up to 100%

To referee these patches:

  1. verify that they fix the coverage to 100%
  2. look for typos in the docstrings
  3. The p-new subspace "serious bugfixes" make it so one doesn't get negative dimensions. This was because the old new subspace code subtracted off the images of old subspaces from the tiny little new subspace instead of subtracting off from the ful l cuspidal subspace.
  4. This is almost all docstring addition and fixing return types to be Integer.

After applying these two patches:

teragon:modular was$ sage -coverage dims.py
----------------------------------------------------------------------
dims.py
SCORE dims.py: 100% (46 of 46)
----------------------------------------------------------------------

Changed 13 years ago by was

Changed 13 years ago by craigcitro

comment:2 Changed 13 years ago by craigcitro

  • Summary changed from [with patch; needs review] doctest -- get coverage of modular/dims.py up to 100% to [with patch; with positive review] doctest -- get coverage of modular/dims.py up to 100%

Looks good. Changed a few comments in doctests, touched up a few things.

comment:3 Changed 13 years ago by craigcitro

I forgot an r on the docstring for mu30. mabshoff is correcting this when he merges.

Changed 13 years ago by mabshoff

Changed 13 years ago by craigcitro

comment:4 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged all six patches in Sage 2.10.4.alpha0

Note: See TracTickets for help on using tickets.