Opened 3 years ago

Closed 3 years ago

#24746 closed enhancement (fixed)

py3 fixes to integer_mod.pyx

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.2
Component: python3 Keywords:
Cc: Merged in:
Authors: Erik Bray, Jeroen Demeyer Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 64c1f28 (Commits, GitHub, GitLab) Commit: 64c1f28d00a4a0b6c3b1bd8904f93de427e2c057
Dependencies: #24749 Stopgaps:

Status badges


Change History (7)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/py3_fixes_to_integer_mod_pyx

comment:2 Changed 3 years ago by git

  • Commit set to 64c1f28d00a4a0b6c3b1bd8904f93de427e2c057

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

58810dcRemove deprecated code from Trac #11802
e9b73d4Remove unused imports
10ec8e8Clean up NativeIntStruct
8083ae1Implement new method set_from_ulong_fast()
3d3dadfFix IntegerMod() function
7b6bd0epy3: fixes to sage.rings.finite_rings.integer_mod to better handle conversion of Python ints to C longs where possible
328d90dClean up integermod constructors
64c1f28Fix IntegerMod maps

comment:3 Changed 3 years ago by jdemeyer

  • Dependencies set to #24749

comment:4 Changed 3 years ago by jdemeyer

  • Status changed from new to needs_review

comment:5 Changed 3 years ago by jdemeyer

Green bot.

comment:6 Changed 3 years ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/py3_fixes_to_integer_mod_pyx to 64c1f28d00a4a0b6c3b1bd8904f93de427e2c057
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.