Opened 2 years ago

Closed 13 months ago

#24718 closed enhancement (invalid)

Use Features for Cremona databases

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: misc Keywords:
Cc: saraedum, fbissey, arojas Merged in:
Authors: Julian Rüth Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/use_features_for_cremona_databases (Commits) Commit: 628f35eea1862e0b147761eb9739ab556e155420
Dependencies: #20382 Stopgaps:

Description (last modified by jdemeyer)

Split off from #20382.

We should also use the database location discovered by the feature check instead of hardcoding it.

Change History (13)

comment:1 Changed 2 years ago by saraedum

Why would you split that off if we already had a positive review anyway?

comment:2 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/use_features_for_cremona_databases

comment:3 Changed 2 years ago by saraedum

  • Branch u/jdemeyer/use_features_for_cremona_databases deleted

Hm…probably I remember incorrectly and there was no positive review yet ;)

comment:4 Changed 2 years ago by saraedum

  • Branch set to u/jdemeyer/use_features_for_cremona_databases
  • Commit set to 628f35eea1862e0b147761eb9739ab556e155420

New commits:

628f35eAdd Features to check the environment at runtime

comment:5 Changed 2 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 2 years ago by fbissey

  • Cc fbissey added

comment:7 Changed 21 months ago by arojas

  • Cc arojas added

comment:8 Changed 21 months ago by jdemeyer

There is a simpler patch at #25825.

comment:9 Changed 21 months ago by saraedum

So, should this be closed in favor of #25825?

comment:10 Changed 21 months ago by jdemeyer

I'll leave that decision to you, I don't know the purpose of your other changes here.

comment:11 Changed 21 months ago by saraedum

  • Milestone changed from sage-8.2 to sage-duplicate/invalid/wontfix
  • Reviewers set to Julian Rüth
  • Status changed from new to needs_review

comment:12 Changed 21 months ago by saraedum

  • Status changed from needs_review to positive_review

comment:13 Changed 13 months ago by embray

  • Resolution set to invalid
  • Status changed from positive_review to closed

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

Note: See TracTickets for help on using tickets.