Opened 4 years ago

Closed 4 years ago

#24670 closed defect (fixed)

Doctest framework fixes for matplotlib

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.2
Component: doctest framework Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: c7471cc (Commits, GitHub, GitLab) Commit: c7471ccee89cd5ffdc6c729815c7bd9d347b959e
Dependencies: #23696 Stopgaps:

Status badges

Description (last modified by jdemeyer)

Since #23696, it is necessary to import matplotlib in the doctest framework. This import was added in a random place, but it really belongs in init_sage().

Change History (5)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/24670

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to a8dbb2f8f14dad90e16b1a39d40ae31154c38d3c
  • Description modified (diff)
  • Status changed from new to needs_review

Last 10 new commits:

4005ec3Fix the arrow matching pattern
3ea7b16build qhull with cmake instead of custom script. This install can then be used by matplotlib.
3a6792eSetting more parameters in sphinx_plot for better 3D documentation
929509euse helper scripts in qhull
d7db6e1Merge branch 'develop' into MPL-2.1.0b
e0534a8Make all doctests set agg as the backend for matplotlib.
a5edbfeChange the startup test for numpy and pyparsing now that they are imported in the doctesting framework via matplotlib.
f65ac29Merge with develop
ca3b242correct test in startup.py
a8dbb2fMove the matplotlib import for doctests to init_sage()

comment:3 Changed 4 years ago by git

  • Commit changed from a8dbb2f8f14dad90e16b1a39d40ae31154c38d3c to c7471ccee89cd5ffdc6c729815c7bd9d347b959e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c7471ccMove the matplotlib import for doctests to init_sage()

comment:4 Changed 4 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Was only put there by ignorance. New spot is much better, hopefully we can get rid of it one day.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/24670 to c7471ccee89cd5ffdc6c729815c7bd9d347b959e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.