Opened 3 years ago

Closed 3 years ago

#24668 closed defect (fixed)

Upgrade to pynac-0.7.16

Reported by: rws Owned by:
Priority: major Milestone: sage-8.2
Component: packages: standard Keywords:
Cc: fbissey Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 2568492 (Commits, GitHub, GitLab) Commit: 2568492aea64d516c2216e5d05e2548c23c66215
Dependencies: Stopgaps:

Status badges

Description

In pynac-0.7.16:

  • Python interface / Py3 fixes and improvements (thx Erik Bray, #24561)
  • atan2 fixes (#24604)
  • beta fixes
  • fix atanh/acoth(real) and polylog (#24299)
  • immediate atanh/acoth --> log simplifications (#24658)
  • legendre_P (#24553)
  • chebyshev_T/U (#16812)
  • speedup in special polynomial creation
  • remove clang-check error
  • remove many clang-tidy warnings
  • remove unused code
  • added CONTRIBUTING.md

​https://github.com/pynac/pynac/releases/download/pynac-0.7.16/pynac-0.7.16.tar.bz2

Change History (12)

comment:1 Changed 3 years ago by rws

  • Branch set to u/rws/upgrade_to_pynac_0_7_16

comment:2 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 67f9ddc48ffe5258b610e1af60ef0ca9fcb7c3db
  • Status changed from new to needs_review

New commits:

​f5b3de424668: version/chzksum
​67f9ddc24668: doctest fixes

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. Next step: to the buildbots.

comment:4 Changed 3 years ago by rws

I'll rebase #24649 on this because of merge conflict.

comment:5 Changed 3 years ago by fbissey

  • Cc fbissey added

comment:6 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Some numerical noise: 

File "src/sage/symbolic/expression.pyx", line 8331, in sage.symbolic.expression.Expression.arctan2
Failed example:
    SR(1).arctan2(CDF(0,1))
Expected:
    0.7853981633974484 - 19.012501686914433*I
Got:
    0.7853981633974483 - 19.012518200244195*I
**********************************************************************
1 item had failures:
   1 of  35 in sage.symbolic.expression.Expression.arctan2
    [2807 tests, 1 failure, 32.96 s]

comment:7 Changed 3 years ago by jdemeyer

The imaginary part changed a lot. More than just the usual numerical noise.

comment:8 Changed 3 years ago by rws

The reason for the relative big error is in the formula that is applied in libs/pynac/pynac.pyx: return -I*py_log((x + I*y)/py_sqrt(x**2 + y**2)) with x=CDF(I), y=1. The denominator sqrt(x**2 + y**2) would be 0, but CDF(I)^2 is -1.0 + 1.2246467991473532e-16*I and so the sqrt denominator becomes 7.82510958117314e-09 + 7.825109581173138e-09*I.

For any other complex type of I as second argument I get an exception so I'm tempted to mark it as known bug.

comment:9 Changed 3 years ago by git

  • Commit changed from 67f9ddc48ffe5258b610e1af60ef0ca9fcb7c3db to 2568492aea64d516c2216e5d05e2548c23c66215

Branch pushed to git repo; I updated commit sha1. New commits:

​256849224668: fix doctest

comment:10 Changed 3 years ago by rws

  • Status changed from needs_work to positive_review

comment:11 Changed 3 years ago by rws

Actually that numeric result was changed in this ticket. Before, the result was not evaluated. However this pynac version tries to evaluate atan2 even with complex values that have nonzero imag part.

comment:12 Changed 3 years ago by vbraun

  • Branch changed from u/rws/upgrade_to_pynac_0_7_16 to 2568492aea64d516c2216e5d05e2548c23c66215
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.