Opened 3 years ago

Closed 3 years ago

#24656 closed defect (fixed)

Fix bug in type E bijection from cythonizing RiggedPartition

Reported by: tscrim Owned by:
Priority: critical Milestone: sage-8.2
Component: combinatorics Keywords: rigged configurations
Cc: sage-combinat, aschilling, bsalisbury01 Merged in:
Authors: Travis Scrimshaw Reviewers: Ben Salisbury
Report Upstream: N/A Work issues:
Branch: 516935c (Commits) Commit: 516935cb4134e2df950e97cf2f9936d6ce34c59e
Dependencies: #24175 Stopgaps:

Description

RiggedPartition.insert_cell now has a signature of an int, so it can no longer take float("inf") to add a cell to the largest row. This was not caught on #24175 because the test was not sufficient. So we also change the test.

Change History (3)

comment:1 Changed 3 years ago by tscrim

  • Branch set to public/combinat/fix_type_E_bijection-24656
  • Commit set to 516935cb4134e2df950e97cf2f9936d6ce34c59e
  • Dependencies set to #24175
  • Status changed from new to needs_review

New commits:

82bc1fbInitial optimization to avoid polytopes for small number of possible choices.
65df5a1Faster _calc_vacancy_number and phi. Cythonized RiggedPartition.
f715a8eMerge branch 'public/combinat/optimize_rc_generation-24175' of git://trac.sagemath.org/sage into public/combinat/fix_type_E_bijection-TBA
516935cFixing bug in type E RC bijection and added a better test.

comment:2 Changed 3 years ago by bsalisbury1

  • Reviewers set to Ben Salisbury
  • Status changed from needs_review to positive_review

comment:3 Changed 3 years ago by vbraun

  • Branch changed from public/combinat/fix_type_E_bijection-24656 to 516935cb4134e2df950e97cf2f9936d6ce34c59e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.