Changes between Initial Version and Version 1 of Ticket #24655, comment 149


Ignore:
Timestamp:
04/20/18 15:43:56 (3 years ago)
Author:
embray
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24655, comment 149

    initial v1  
    1 I forget--is there a reason we ''don't'' run `runsphinx()` in a subprocess?  Because `sphinx.cmdline.main()` wasn't really ever meant to be invoked as an API in a larger script, and it leaves around all kinds of global state.  Just for example just the `logging` module's root logger hangs on to a reference the Sphinx app, and I'm sure there are other examples.
     1I forget--is there a reason we ''don't'' run `runsphinx()` in a subprocess?  Because `sphinx.cmdline.main()` wasn't really ever meant to be invoked as an API in a larger script, and it leaves around all kinds of global state.  Just for example:
     2
     3* the `logging` module's root logger hangs on to a reference the Sphinx app
     4* the `matplotlib.sphinxext.plot_directive.setup` function holds on to a reference to the app for some reason
     5
     6and there might be other examples.