Changes between Initial Version and Version 1 of Ticket #24655, comment 112
- Timestamp:
- 04/05/18 10:45:16 (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #24655, comment 112
initial v1 3 3 I had to remind myself exactly how this works though. It does not start the container with `sage -sh` like I suggested previously. I think I ran into some problems with that as well. However, my solution does take many of the environment variables that result from running `sage -sh` and sets them by default in the container: 4 4 5 https://github.com/sagemath/docker-images/commit/acbfc7d54d435cf11b6325e93eab2c3dfe9ee48c 5 https://github.com/sagemath/docker-images/commit/acbfc7d54d435cf11b6325e93eab2c3dfe9ee48c#diff-9cf7721d3a01b10049e0d9f6e29e4058R45 6 6 7 I think it would be good to keep something like this. 7 I think it would be good to keep something like this. Actually, it's very important for binder to work correctly since it also ensures that it's running the Jupyter installed with Sage.