Opened 5 years ago

Closed 5 years ago

#24638 closed defect (fixed)

Fix OpenBLAS build on SPARC

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-8.2
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Dima Pasechnik
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: e350b30 (Commits, GitHub, GitLab) Commit: e350b306612946bcc407efeebee331441d5728c5
Dependencies: Stopgaps:

Status badges

Change History (14)

comment:1 Changed 5 years ago by Jeroen Demeyer

Branch: u/jdemeyer/fix_openblas_build_on_sparc

comment:2 Changed 5 years ago by Jeroen Demeyer

Commit: b76a7663c14e5e8ffa7e3003577ef21d8c225eb5
Status: newneeds_review

New commits:

b76a766Fix OpenBLAS build on SPARC

comment:3 Changed 5 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

looks good to me.

comment:4 Changed 5 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

Still fails to build because of a different error:

openblas_get_config.c:58:3: error: expected ',' or ';' before 'CHAR_CORENAME'
   CHAR_CORENAME
   ^
openblas_get_config.c: In function 'openblas_get_corename':
openblas_get_config.c:81:10: error: 'CHAR_CORENAME' undeclared (first use in this function)
   return CHAR_CORENAME;
          ^
openblas_get_config.c:81:10: note: each undeclared identifier is reported only once for each function it appears in
openblas_get_config.c:85:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[3]: *** [Makefile:113: openblas_get_config.o] Error 1

comment:5 Changed 5 years ago by Jeroen Demeyer

Description: modified (diff)
Report Upstream: Fixed upstream, but not in a stable release.Reported upstream. No feedback yet.

comment:6 Changed 5 years ago by Jeroen Demeyer

Description: modified (diff)
Report Upstream: Reported upstream. No feedback yet.Fixed upstream, but not in a stable release.

comment:7 Changed 5 years ago by git

Commit: b76a7663c14e5e8ffa7e3003577ef21d8c225eb5a4d4ff4daf2a603f2211d16708fa4cefbbf4dab6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a4d4ff4Fix OpenBLAS build on SPARC

comment:8 Changed 5 years ago by Jeroen Demeyer

Status: needs_workneeds_review

comment:9 Changed 5 years ago by git

Commit: a4d4ff4daf2a603f2211d16708fa4cefbbf4dab6e350b306612946bcc407efeebee331441d5728c5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e350b30Fix OpenBLAS build on SPARC

comment:10 Changed 5 years ago by Jeroen Demeyer

This now actually works.

comment:11 Changed 5 years ago by Dima Pasechnik

I will test it in due course, I'd proceed with the Atlas build for the time being.

comment:12 Changed 5 years ago by Dima Pasechnik

This builds with gcc 7.2 on Solaris. Needs testing, still.

comment:13 Changed 5 years ago by Dima Pasechnik

Status: needs_reviewpositive_review

Looks good to go.

comment:14 Changed 5 years ago by Volker Braun

Branch: u/jdemeyer/fix_openblas_build_on_sparce350b306612946bcc407efeebee331441d5728c5
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.