Changes between Version 28 and Version 31 of Ticket #24623


Ignore:
Timestamp:
04/27/18 05:51:45 (19 months ago)
Author:
tscrim
Comment:

Okay, I have made my way through the code. Overall, it looks good.

I remove the function EuclideanSpace and just used the __classcall_private__ mechanism (provided by UniqueRepresentation) to make the class EuclideanSpace (formerly EuclideanSpaceGeneric) the main entry point.

There is something very subtle happening as some of the doctest output for display names of arctan2(y, x) needed to be arctan(y/x). I do not understand why nor could I see what was causing this. It is not a blocker issue, but it is an indication that something might not be working properly.

The rest of my changes were mostly cosmetic.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24623

    • Property Reviewers changed from to Travis Scrimshaw
    • Property Commit changed from de74bb734f9f531bb6d991b14af20e58e6ebd683 to ab249df0d9dc01064ef68dd366941fe38e5a8e13
  • Ticket #24623 – Description

    v28 v31  
    33See this [https://ask.sagemath.org/question/40792/div-grad-and-curl-once-again/ ask.sagemath question] for a motivation, as well as this [https://ask.sagemath.org/question/41898/ one].
    44
    5 The implementation is performed via the parent class `EuclideanSpaceGeneric`, which inherits from `PseudoRiemannianManifold` (introduced in #24622). Two subclasses are devoted to specific cases:
     5The implementation is performed via the parent class `EuclideanSpace`, which inherits from `PseudoRiemannianManifold` (introduced in #24622). Two subclasses are devoted to specific cases:
    66- `EuclideanPlane` for n=2
    77- `Euclidean3dimSpace` for n=3
    8 The user interface for constructing an Euclidean space relies on a single function: `EuclideanSpace`.
     8The user interface for constructing an Euclidean space relies on the `EuclideanSpace.__classcall_private__` to direct to the appropriate subclass.
    99
    1010The implementation through the manifold framework allows for an easy use of various coordinate systems, along with the related transformations. However, the user interface does not assume any knowledge of Riemannian geometry. In particular, no direct manipulation of the metric tensor is required.