Opened 3 years ago

Closed 3 years ago

#24621 closed defect (fixed)

Fix conversions to CBF

Reported by: mmezzarobba Owned by:
Priority: major Milestone: sage-8.2
Component: numerical Keywords:
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Vinent Delecroix
Report Upstream: N/A Work issues:
Branch: 8474ea3 (Commits, GitHub, GitLab) Commit: 8474ea3c302e87aceb0b6362ce9e183e3ebf6b1a
Dependencies: Stopgaps:

Status badges

Description

#24285 breaks some conversions to CBF, e.g. 

sage: CBF(NumberField(polygen(QQ, 'y')^3 + 20, 'a', embedding=CC(1.35,2.35)).gen())
...
TypeError: unable to convert a to a ComplexBall

Change History (3)

comment:1 Changed 3 years ago by mmezzarobba

  • Branch set to u/mmezzarobba/ticket/24621
  • Commit set to 8474ea3c302e87aceb0b6362ce9e183e3ebf6b1a
  • Status changed from new to needs_review

New commits:

​8474ea3Fix up 75c75e9 (#24285)

comment:2 Changed 3 years ago by vdelecroix

  • Reviewers set to Vinent Delecroix
  • Status changed from needs_review to positive_review

comment:3 Changed 3 years ago by vbraun

  • Branch changed from u/mmezzarobba/ticket/24621 to 8474ea3c302e87aceb0b6362ce9e183e3ebf6b1a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.