Opened 3 years ago

Last modified 3 years ago

#24609 needs_work defect

Cython vtable warnings in padics

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.2
Component: padics Keywords: padicIMA
Cc: roed Merged in:
Authors: Julian Rüth Reviewers:
Report Upstream: N/A Work issues: rename right to other; add p parameter to val_unit everywhere
Branch: u/saraedum/24609 (Commits, GitHub, GitLab) Commit: a0bac48a9dd243f7ee3445cf6e2327e1850070df
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

warning: sage/rings/padics/CR_template.pxi:779:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/CR_template.pxi:1396:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/FP_template.pxi:1096:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'FPElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/CR_template.pxi:779:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/CR_template.pxi:1396:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/FP_template.pxi:1096:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'FPElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/padic_generic_element.pyx:279:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'pAdicGenericElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/padic_generic_element.pyx:390:10: Compatible but non-identical C method '_mod_' not redeclared in definition part of extension type 'pAdicGenericElement'.  This may cause incorrect vtables to be generated.

This is part of #23600.

Change History (10)

comment:1 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 3 years ago by roed

  • Keywords padicIMA added

comment:3 Changed 3 years ago by saraedum

  • Authors set to Julian Rüth

comment:4 Changed 3 years ago by saraedum

  • Branch set to u/saraedum/24609

comment:5 Changed 3 years ago by saraedum

  • Commit set to a0bac48a9dd243f7ee3445cf6e2327e1850070df
  • Status changed from new to needs_review
  • Work issues set to is the patchbot happy?

New commits:

a0bac48Fixes Cython warnings

comment:6 Changed 3 years ago by saraedum

I have not tested this, but the warnings are gone.

comment:7 Changed 3 years ago by jdemeyer

Minor nitpick, but could you use self, other instead of self, right?

comment:8 Changed 3 years ago by saraedum

The implementation uses right. So I should change all the implementations as well I guess?

Last edited 3 years ago by saraedum (previous) (diff)

comment:9 Changed 3 years ago by jdemeyer

I don't care so much. Whatever you feel like.

comment:10 Changed 3 years ago by saraedum

  • Status changed from needs_review to needs_work
  • Work issues changed from is the patchbot happy? to rename right to other; add p parameter to val_unit everywhere
Note: See TracTickets for help on using tickets.