Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#24602 closed defect (fixed)

upgrade iconv to 1.15

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.2
Component: packages: standard Keywords:
Cc: fbissey, jdemeyer Merged in:
Authors: Dima Pasechnik Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: e6237fb (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

1.15 was released last year. It fixes a bug in 1.14 that can be seen while building Sage on SPARC Solaris 11.

...
gcc -m64 -DHAVE_CONFIG_H -DEXEEXT=\"\" -I. -I.. -I../lib  -I../intl -DDEPENDS_ON_LIBICONV=1 -DDEPENDS_ON_LIBINTL=1   -D_XPG6 -c progname.c
In file included from /usr/include/sys/time.h:477:0,
                 from /usr/include/sys/select.h:28,
                 from /usr/include/sys/types.h:664,
                 from ./stdio.h:58,
                 from progname.c:26:
./stdio.h:1010:1: error: 'gets' undeclared here (not in a function); did you mean 'getw'?
 _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
 ^
make[5]: *** [Makefile:914: progname.o] Error 1

(it's because in 1.14 an unreasonable assumption is made about what's available in the toolchain, some kind of GNUism).

The update is trivial to do.

The tarball: https://ftp.gnu.org/pub/gnu/libiconv/libiconv-1.15.tar.gz

Change History (7)

comment:1 Changed 4 years ago by dimpase

  • Branch set to u/dimpase/iconv115
  • Cc fbissey added
  • Commit set to e6237fbfe56870290b8524458d2740ee85b2668a
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by dimpase

  • Cc jdemeyer added

comment:3 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:4 Changed 4 years ago by embray

Apologies for the weird patchbot results on this ticket. I'm experimenting with a new update to the patchbot to allow it to test tickets with spkg updates, and I sort of at random picked this one as a guinea pig.

comment:5 Changed 4 years ago by dimpase

"... news outlets are reporting a noisy crowd of animal rights advocates protesting at Sagemath Headquarters, while a group of climbers just attached a huge banner saying "Hands off guinea pigs!" on the front wall..."

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/dimpase/iconv115 to e6237fbfe56870290b8524458d2740ee85b2668a
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 4 years ago by embray

  • Commit e6237fbfe56870290b8524458d2740ee85b2668a deleted

Hah! :-)

Note: See TracTickets for help on using tickets.