Opened 5 years ago

Closed 5 years ago

#24597 closed defect (fixed)

Properly set LD_LIBRARY_PATH in spkg-build for python2/3 on SunOS

Reported by: Dima Pasechnik Owned by:
Priority: major Milestone: sage-8.2
Component: build Keywords:
Cc: Erik Bray, Jeroen Demeyer Merged in:
Authors: Dima Pasechnik Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 364ec35 (Commits, GitHub, GitLab) Commit: 364ec35f1cbdab920e52c44341b8c19c8183b818
Dependencies: Stopgaps:

Status badges

Description (last modified by Dima Pasechnik)

this is to allow Solaris build to go through, see sage-devel post

Part of #24596

Change History (6)

comment:1 Changed 5 years ago by Erik Bray

Summary: properly unset LD_LIBRARY_PATH in spkg-build for python2/3Properly set LD_LIBRARY_PATH in spkg-build for python2/3 on SunOS

comment:2 Changed 5 years ago by Dima Pasechnik

Branch: u/dimpase/ldlibpath
Commit: 364ec35f1cbdab920e52c44341b8c19c8183b818
Status: newneeds_review

New commits:

364ec35LD_LIBRARY_PATH="." everywhere except OSX

comment:3 Changed 5 years ago by Dima Pasechnik

Description: modified (diff)

comment:4 Changed 5 years ago by Dima Pasechnik

Cc: Jeroen Demeyer added

comment:5 Changed 5 years ago by Erik Bray

Reviewers: Erik Bray
Status: needs_reviewpositive_review

Looks good to me. Setting LD_LIBRARY_PATH on Cygwin is mostly pointless (it only affects dlopen()) but it should be harmless all the same.

comment:6 Changed 5 years ago by Volker Braun

Branch: u/dimpase/ldlibpath364ec35f1cbdab920e52c44341b8c19c8183b818
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.