Opened 4 years ago

Closed 4 years ago

#24591 closed task (fixed)

Global function fields: basic classes

Reported by: klee Owned by:
Priority: minor Milestone: sage-8.3
Component: algebra Keywords:
Cc: jsrn Merged in:
Authors: Kwankyu Lee Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d5ad194 (Commits, GitHub, GitLab) Commit: d5ad194457d7dfa108d868796b4f241af08f9072
Dependencies: Stopgaps:

Status badges

Description

This is part of the meta-ticket #22982.

The goal of the present ticket is to trim the existing code and add several classes that are now just stubs, to prepare for the next step.

Change History (17)

comment:1 Changed 4 years ago by klee

  • Branch set to u/klee/24591

comment:2 Changed 4 years ago by git

  • Commit set to 3c46c032c635ea0c5c30968d157bc4e2acce4ca7

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

3b37339Add back proof=True to _factor method
daed064Remove differentials code
07abebbRemove differentials code
639c2fdRemove differentials docstrings
836ed53Remove divisors code
8cf530fRemove places and valuation code
895572cRemove ideals code
f4bc048Rename element ideal order files
50efcbbRename ideal order element modules
3c46c03Remove orders code

comment:3 Changed 4 years ago by klee

  • Authors set to Kwankyu Lee
  • Status changed from new to needs_review

comment:4 Changed 4 years ago by klee

  • Status changed from needs_review to needs_work

comment:5 Changed 4 years ago by klee

  • Status changed from needs_work to needs_review

comment:6 Changed 4 years ago by git

  • Commit changed from 3c46c032c635ea0c5c30968d157bc4e2acce4ca7 to cc3b89791f591d8984fed21497e13d9655539172

Branch pushed to git repo; I updated commit sha1. New commits:

cc3b897Small trimmings

comment:7 Changed 4 years ago by git

  • Commit changed from cc3b89791f591d8984fed21497e13d9655539172 to 84acd60edfa7ff5363c75b8062eeae0dce506eb3

Branch pushed to git repo; I updated commit sha1. New commits:

84acd60Merge develop

comment:8 Changed 4 years ago by jsrn

  • Cc jsrn added

comment:9 Changed 4 years ago by git

  • Commit changed from 84acd60edfa7ff5363c75b8062eeae0dce506eb3 to 2ff0e2b63704ced08afd0b58c5899538423f148b

Branch pushed to git repo; I updated commit sha1. New commits:

2ff0e2bPolish the docstring for _inversion_isomorphism

comment:10 Changed 4 years ago by git

  • Commit changed from 2ff0e2b63704ced08afd0b58c5899538423f148b to 123536f67838b5d2ac8e5b675df428928cbe0139

Branch pushed to git repo; I updated commit sha1. New commits:

123536fMerge develop

comment:11 Changed 4 years ago by git

  • Commit changed from 123536f67838b5d2ac8e5b675df428928cbe0139 to 230b7056fc31653693429db068b9146fcd6d224f

Branch pushed to git repo; I updated commit sha1. New commits:

230b705Merge develop

comment:12 Changed 4 years ago by git

  • Commit changed from 230b7056fc31653693429db068b9146fcd6d224f to a28e7bcbaf49e8e20d075db642120c7720e8cdc7

Branch pushed to git repo; I updated commit sha1. New commits:

a28e7bcMerge develop

comment:13 Changed 4 years ago by git

  • Commit changed from a28e7bcbaf49e8e20d075db642120c7720e8cdc7 to 1665c3fa124293144840f977f9cd054e34676177

Branch pushed to git repo; I updated commit sha1. New commits:

1665c3fMerge develop

comment:14 Changed 4 years ago by tscrim

  • Branch changed from u/klee/24591 to u/tscrim/basic_classes_global_function_fields-24591
  • Commit changed from 1665c3fa124293144840f977f9cd054e34676177 to d5ad194457d7dfa108d868796b4f241af08f9072
  • Reviewers set to Travis Scrimshaw

I pushed some reviewer changes. If my changes look good, then positive review.


New commits:

d5ad194Reviewer changes.

comment:15 Changed 4 years ago by klee

  • Status changed from needs_review to positive_review

Positive review on the reviewer's changes. Thanks!

comment:16 Changed 4 years ago by klee

  • Milestone changed from sage-8.2 to sage-8.3

comment:17 Changed 4 years ago by vbraun

  • Branch changed from u/tscrim/basic_classes_global_function_fields-24591 to d5ad194457d7dfa108d868796b4f241af08f9072
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.