Opened 3 years ago

Closed 3 years ago

#24576 closed enhancement (fixed)

Brown invariant of a TorsionQuadraticModule

Reported by: sbrandhorst Owned by:
Priority: major Milestone: sage-8.2
Component: quadratic forms Keywords:
Cc: Merged in:
Authors: Simon Brandhorst Reviewers: Kenji Hashimoto
Report Upstream: N/A Work issues:
Branch: 4fa9c86 (Commits) Commit: 4fa9c869ff3cc698edd95f3196479de028e4894e
Dependencies: #24035 Stopgaps:

Description

Implement a method for sage.modules.torsion_quadratic_module.TorsionQuadraticModule

that returns the Brown invariant of the torsion quadratic form.

Change History (14)

comment:1 Changed 3 years ago by sbrandhorst

  • Branch set to u/sbrandhorst/brown_invariant_of_a_torsionquadraticmodule

comment:2 Changed 3 years ago by git

  • Commit set to 2c406fba5e69ed17442453317c65e00e7b92efc2

Branch pushed to git repo; I updated commit sha1. New commits:

​2c406fbThe Brown invariant.

comment:3 Changed 3 years ago by sbrandhorst

  • Status changed from new to needs_review

comment:4 Changed 3 years ago by git

  • Commit changed from 2c406fba5e69ed17442453317c65e00e7b92efc2 to b2acff73a24a723c3fade8bbedb977e3522462f1

Branch pushed to git repo; I updated commit sha1. New commits:

​b2acff7Merge branch 'develop' of git://trac.sagemath.org/sage into t/24576/brown_invariant_of_a_torsionquadraticmodule

comment:5 Changed 3 years ago by git

  • Commit changed from b2acff73a24a723c3fade8bbedb977e3522462f1 to fb9153e5b929c0114d98a069d9c9927b06371c23

Branch pushed to git repo; I updated commit sha1. New commits:

​5097c40Precision bugfix.
​5a98659SEEALSO: --> SEEALSO::
​987417dDoc formating in torsion_quadratic_module.py
​05927caMerge branch 'develop' of git://trac.sagemath.org/sage into t/24035/orthogonal_jordan_decomposition_for_torsionquadraticmodules
​8f944ccDoc formatting.
​0600a54Documentation only
​a88fbf6Change in convention for the normal form of a p-torsion module.
​9ae1c13Revert "Change in convention for the normal form of a p-torsion module."
​fb9153eMerge commit '9ae1c1369b171d417e7a291055fa747335244abe' of git://trac.sagemath.org/sage into t/24576/brown_invariant_of_a_torsionquadraticmodule

comment:6 Changed 3 years ago by khashimoto

  • Branch changed from u/sbrandhorst/brown_invariant_of_a_torsionquadraticmodule to u/khashimoto/brown_invariant_of_a_torsionquadraticmodule

comment:7 Changed 3 years ago by khashimoto

  • Commit changed from fb9153e5b929c0114d98a069d9c9927b06371c23 to 9bb6049bf0d858af5e9e80aabbe418049ec65ac8
  • Reviewers set to Kenji Hashimoto
  • Status changed from needs_review to positive_review

Corrected typos in documentation

New commits:

​9bb6049Corrected documentation

comment:8 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict, please merge in next beta

comment:9 Changed 3 years ago by sbrandhorst

  • Branch changed from u/khashimoto/brown_invariant_of_a_torsionquadraticmodule to u/sbrandhorst/brown_invariant_of_a_torsionquadraticmodule

comment:10 Changed 3 years ago by sbrandhorst

  • Commit changed from 9bb6049bf0d858af5e9e80aabbe418049ec65ac8 to 2ced0bb341cbc16d3ea0b7e347689c098698cf12
  • Status changed from needs_work to positive_review

New commits:

​2ced0bbMerge branch 'develop' into t/24576/brown_invariant_of_a_torsionquadraticmodule

comment:11 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:12 Changed 3 years ago by git

  • Commit changed from 2ced0bb341cbc16d3ea0b7e347689c098698cf12 to 4fa9c869ff3cc698edd95f3196479de028e4894e

Branch pushed to git repo; I updated commit sha1. New commits:

​4825174Fixed a bug in normal_form of a torsion_quadratic_module
​893ba1ctrivial doc change
​2babaaeMerge branch 'develop' into t/24864/bug_in_torsionquadraticform_normal_form__
​4fa9c86Merge commit '2babaae5c749a2d558095ae5a4c973df13501e23' of git://trac.sagemath.org/sage into t/24576/brown_invariant_of_a_torsionquadraticmodule

comment:13 Changed 3 years ago by sbrandhorst

  • Status changed from needs_work to positive_review

Should be O.K. now. Was a trivial conflict in imports.

comment:14 Changed 3 years ago by vbraun

  • Branch changed from u/sbrandhorst/brown_invariant_of_a_torsionquadraticmodule to 4fa9c869ff3cc698edd95f3196479de028e4894e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.