Opened 3 years ago
Closed 3 years ago
#24570 closed enhancement (fixed)
py3: using the new tags py3 and py2 in some rst files
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.2 |
Component: | python3 | Keywords: | |
Cc: | jdemeyer, tscrim, fbissey, embray | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | 1aa0545 (Commits, GitHub, GitLab) | Commit: | 1aa054511b865a961036251b5cc76870d3f41ee8 |
Dependencies: | Stopgaps: |
Description
replacing the former "optional - py2" used there.
Change History (9)
comment:1 Changed 3 years ago by
- Branch set to u/chapoton/24570
- Commit set to 1aa054511b865a961036251b5cc76870d3f41ee8
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
I wonder if we can somehow make the documentation builder actually omit the #py2
or #py3
lines depending on which python the docs are being built against. Or if that's even really desirable.
comment:3 follow-up: ↓ 6 Changed 3 years ago by
Erik, this is a bit frustrating that you alone have a branch where you can launch doctests in python3.
How far are we from having vanilla sage build and start with python3 ? I think after #24223, we will be very close but not quite there. In my opinion, we should aim to reach that state as soon as possible. And the next step would be to be able to use "sage -t" in vanilla sage+py3.
comment:4 Changed 3 years ago by
bot is morally green
comment:5 Changed 3 years ago by
ping ?
comment:6 in reply to: ↑ 3 Changed 3 years ago by
Replying to chapoton:
Erik, this is a bit frustrating that you alone have a branch where you can launch doctests in python3.
I don't think that's true. I'm sure I've pointed you to #24343 which has the fixes necessary for the doctest runner to work, at least I think. You can always merge that in to your local branch and try it--I'd assumed you already have been.
comment:7 Changed 3 years ago by
could please somebody review this very easy ticket ?
comment:8 Changed 3 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to positive_review
comment:9 Changed 3 years ago by
- Branch changed from u/chapoton/24570 to 1aa054511b865a961036251b5cc76870d3f41ee8
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
py3: using the new tags py2 and py3 in the rst files