Opened 4 years ago

Closed 4 years ago

#24553 closed enhancement (fixed)

Make legendre_P() a GinacFunction

Reported by: rws Owned by:
Priority: major Milestone: sage-8.2
Component: performance Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6c0ef30 (Commits, GitHub, GitLab) Commit: 6c0ef30556dc1c55b0e3f0b51c946171b3738bcc
Dependencies: #24668 Stopgaps:

Status badges

Description (last modified by rws)

Pynac-0.7.16 offers legendre_P(). The performance increase:

                            Python+Pari        Pynac
                            -----------        -----
sage: _=legendre_P(10,x)      510 µs           29 µs
sage: _=legendre_P(100,x)     2.3 ms           290 µs
sage: _=legendre_P(1000,x)    28 ms            3.5 ms
sage: _=legendre_P(10000,x)   1.1 s            110 ms
sage: _=legendre_P(50000,x)   30 s             2.1 s

overall a speedup of a comfortable order of magnitude.

Change History (9)

comment:1 Changed 4 years ago by rws

  • Branch set to u/rws/make_legendre_p___a_ginacfunction

comment:2 Changed 4 years ago by rws

  • Commit set to 6c0ef30556dc1c55b0e3f0b51c946171b3738bcc
  • Description modified (diff)

New commits:

6c0ef3024553: Make legendre_P() a GinacFunction

comment:3 follow-up: Changed 4 years ago by tscrim

Ready for review?

comment:4 Changed 4 years ago by rws

  • Dependencies set to pynac-0.7.16

It will not work without pynac-0.7.16.

comment:5 Changed 4 years ago by rws

  • Authors set to Ralf Stephan
  • Dependencies changed from pynac-0.7.16 to #24668
  • Status changed from new to needs_review

comment:6 in reply to: ↑ 3 Changed 4 years ago by rws

Replying to tscrim:

Ready for review?

Yes, please.

comment:7 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 4 years ago by rws

Thanks!

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/rws/make_legendre_p___a_ginacfunction to 6c0ef30556dc1c55b0e3f0b51c946171b3738bcc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.