Opened 2 years ago
Closed 23 months ago
#24549 closed enhancement (fixed)
Clean up MPC declarations
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.2 |
Component: | cython | Keywords: | |
Cc: | vklein | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Vincent Klein |
Report Upstream: | N/A | Work issues: | |
Branch: | b1047cc (Commits) | Commit: | b1047cce75651690fda2ee0a64d59b56110634b3 |
Dependencies: | Stopgaps: |
Description
Change History (12)
comment:1 Changed 2 years ago by
- Cc vklein added
comment:2 Changed 2 years ago by
- Branch set to u/jdemeyer/clean_up_mpc_declarations
comment:3 Changed 2 years ago by
- Commit set to b1047cce75651690fda2ee0a64d59b56110634b3
- Status changed from new to needs_review
comment:4 Changed 2 years ago by
- Reviewers set to vklein
comment:5 Changed 2 years ago by
make ptestlong works for me. I just don't see what is missing for the three patchbot with failures.
comment:6 Changed 2 years ago by
I have a failure with fricas package installed.
sage$ sage -i fricas ... ... sage$ sage -t --long --warn-long 73.9 src/sage/interfaces/fricas.py ********************************************************************** File "src/sage/interfaces/fricas.py", line 1097, in sage.interfaces.fricas.FriCASElement._sage_expression Failed example: [f(x)._fricas_().sage().subs(x=0.9) for f in l] # optional - fricas Expected: [0.716297870199024, 1.02651672570818, 1.43308638544877, 1.39606725303001, 0.697794641100332, 0.974168247780004, 0.808866935652782, NaN, 1.47221948958322, NaN, 0.467145308103262, 0.957800449200672, 0.808866935652782, NaN, 1.47221948958322, NaN, 0.467145308103262, 0.957800449200672] Got: [0.716297870199024, 1.02651672570818, 1.43308638544877, 1.39606725303001, 0.697794641100332, 0.974168247780004, 0.808866935652782, 0.451026811796262*I, 1.47221948958322, 1.47221948958322, 0.467145308103262, 0.957800449200672, 0.808866935652782, 0.451026811796262*I, 1.47221948958322, 1.47221948958322, 0.467145308103262, 0.957800449200672] ********************************************************************** 1 item had failures: 1 of 10 in sage.interfaces.fricas.FriCASElement._sage_expression [173 tests, 1 failure, 38.38 s] ---------------------------------------------------------------------- sage -t --long --warn-long 73.9 src/sage/interfaces/fricas.py # 1 doctest failed
I am currently testing with 8.2.beta2 to see if it is a side effect of this ticket.
comment:7 Changed 2 years ago by
I get the same error with 8.2.beta2.
The remaining failures in patchbot are in cone.py and special.py:
K = random_cone(min_ambient_dim=3, # long time max_ambient_dim=3, # long time min_rays=7) # long time
this one may be hard to reproduce.
special.py : Failures with random_matrix results.
Does anybody knows what can cause this ?
comment:8 Changed 2 years ago by
Fricas doctest failure already has a ticket #24426.
comment:9 Changed 2 years ago by
Ignore the patchbot failures. They all have tickets already.
comment:11 Changed 2 years ago by
- Reviewers changed from vklein to Vincent Klein
The "Reviewer" field of the ticket must be your full name and not your login.
comment:12 Changed 23 months ago by
- Branch changed from u/jdemeyer/clean_up_mpc_declarations to b1047cce75651690fda2ee0a64d59b56110634b3
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Clean up MPC declarations