Opened 3 years ago

Closed 3 years ago

#24527 closed enhancement (fixed)

py3: remove one call to long in rand_seed

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: python3 Keywords:
Cc: embray Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 22b1128 (Commits, GitHub, GitLab) Commit: 22b112867951bf4818456aab106e94750da1a7e5
Dependencies: Stopgaps:

Status badges

Description


Change History (9)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/24527
  • Commit set to b9d9d26d3d5f6cee7f58fc214b81a9bd9f3ad8fd
  • Status changed from new to needs_review

New commits:

b9d9d26py3: remove one remaining long( )

comment:2 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to needs_work

I agree in principle but the doctests should be updated because this changes the output type of rand_seed(). Also, it would be good to have a doctest for the type:

sage: type(s.rand_seed())
<type 'int'>

comment:3 follow-up: Changed 3 years ago by chapoton

Well, in fact the doctests remain long..

comment:4 Changed 3 years ago by git

  • Commit changed from b9d9d26d3d5f6cee7f58fc214b81a9bd9f3ad8fd to 22b112867951bf4818456aab106e94750da1a7e5

Branch pushed to git repo; I updated commit sha1. New commits:

22b1128detail

comment:5 in reply to: ↑ 3 Changed 3 years ago by jdemeyer

Replying to chapoton:

Well, in fact the doctests remain long..

Yes, you are right. So there was absolutely no reason for the long() anyway...

comment:6 Changed 3 years ago by chapoton

So, positive review ?

comment:7 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_work to needs_review

Yes if the patchbot gives the green light

comment:8 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, thanks!

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/24527 to 22b112867951bf4818456aab106e94750da1a7e5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.