#2451 closed defect (fixed)
[with patch; positive review] plotting -- contour_plot and plot_vector_field are REALLY SLOW but it's easy to get a million times speedup
Reported by: | was | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-2.10.3 |
Component: | graphics | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
There are two problems:
- neither use _fast_float
- Even worse, they don't coerce their endpoints to floats. This is a killer.
To illustrate:
var('x,y') sage: time contour_plot(x^2+y^2, (-pi,pi),(-pi,pi)) takes forever sage: time contour_plot(x^2+y^2, (-float(pi),float(pi)),(-float(pi),float(pi))) takes forever sage: f = (x^2+y^2)._fast_float_('x','y') sage: time contour_plot(f, (-float(pi),float(pi)),(-float(pi),float(pi))) CPU times: user 0.00 s, sys: 0.00 s, total: 0.00 s
Attachments (1)
Change History (8)
comment:1 Changed 15 years ago by
Status: | new → assigned |
---|
Changed 15 years ago by
Attachment: | sage-2451.patch added |
---|
comment:2 Changed 15 years ago by
Summary: | plotting -- contour_plot and plot_vector_field are REALLY SLOW but it's easy to get a million times speedup → [with patch; needs review] plotting -- contour_plot and plot_vector_field are REALLY SLOW but it's easy to get a million times speedup |
---|
comment:3 Changed 15 years ago by
Summary: | [with patch; needs review] plotting -- contour_plot and plot_vector_field are REALLY SLOW but it's easy to get a million times speedup → [with patch; Positive review pending patch ] plotting -- contour_plot and plot_vector_field are REALLY SLOW but it's easy to get a million times speedup |
---|
Positive review pending patch of redundant line 4239.
comment:4 Changed 15 years ago by
Summary: | [with patch; Positive review pending patch ] plotting -- contour_plot and plot_vector_field are REALLY SLOW but it's easy to get a million times speedup → [with patch; positive review] plotting -- contour_plot and plot_vector_field are REALLY SLOW but it's easy to get a million times speedup |
---|
I did remove the offending line after merging the patch.
Cheers,
Michael
comment:5 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Merged in Sage 2.10.3.rc4
comment:6 Changed 15 years ago by
works as advertised in my limited testing.
gfurnish indicates that line 4239 is redundant
Note: See
TracTickets for help on using
tickets.
part 1. there may be a part 2...