Opened 18 months ago
Closed 18 months ago
#24497 closed defect (fixed)
Upgrade to pynac0.7.15
Reported by:  rws  Owned by:  

Priority:  major  Milestone:  sage8.2 
Component:  packages: standard  Keywords:  
Cc:  fbissey  Merged in:  
Authors:  Ralf Stephan  Reviewers:  Jeroen Demeyer 
Report Upstream:  N/A  Work issues:  
Branch:  d085587 (Commits)  Commit:  d085587a0f4319f03a830c39eb5b3d83836f18dd 
Dependencies:  Stopgaps: 
Description (last modified by )
In 0.7.15:
 fix mpz conversion (#24418)
 fix
infinity.info()
,function.info()
,power.info(negative)
 fix
symbol.real/imag_part()
 fix bug showing with nonnumeric rationals
 fix Python import from
sage.rings
 rational symbol domain (#24368)
 implement
constant.is_nonzero()
(#18630)  fully implement
info(even)
(#24351)  fully implement
info(nonzero)
 fully implement
info(rational)
https://github.com/pynac/pynac/releases/download/pynac0.7.15/pynac0.7.15.tar.bz2
Change History (21)
comment:1 Changed 18 months ago by
 Description modified (diff)
comment:2 Changed 18 months ago by
 Branch set to u/rws/upgrade_to_pynac_0_7_15
comment:3 Changed 18 months ago by
 Commit set to 880ebf30d4361148b58407e88af8e55f8ae6863a
 Status changed from new to needs_review
comment:4 Changed 18 months ago by
 Cc fbissey added
comment:5 Changed 18 months ago by
All tests pass on quasar.
comment:6 Changed 18 months ago by
The only thing I'm not sure about is the change in modular/modform_hecketriangle/graded_ring_element.py
. Can you explain the rationale?
comment:7 followup: ↓ 10 Changed 18 months ago by
The former result changes quite a bit, I think because small changes are enlarged by substitution into a polynomial. I tried to preserve the assumed spirit of the test, i.e. a nonzero real part of the result, but to make it more robust. Of course I may be wrong with my assumptions.
comment:8 Changed 18 months ago by
Passes tests on sardonis (ppc64le) too.
comment:9 Changed 18 months ago by
 Branch changed from u/rws/upgrade_to_pynac_0_7_15 to u/jdemeyer/upgrade_to_pynac_0_7_15
comment:10 in reply to: ↑ 7 ; followup: ↓ 11 Changed 18 months ago by
 Commit changed from 880ebf30d4361148b58407e88af8e55f8ae6863a to 70275ab3f3d45469522f3fd75a37a5550727aa0c
Replying to rws:
The former result changes quite a bit, I think because small changes are enlarged by substitution into a polynomial. I tried to preserve the assumed spirit of the test, i.e. a nonzero real part of the result, but to make it more robust. Of course I may be wrong with my assumptions.
I kept the test but adjusted the answer. Does that work for you?
New commits:
70275ab  24497: doctest fixes

comment:11 in reply to: ↑ 10 Changed 18 months ago by
comment:12 Changed 18 months ago by
 Reviewers set to Jeroen Demeyer
 Status changed from needs_review to positive_review
comment:13 Changed 18 months ago by
Thanks for the review.
comment:14 Changed 18 months ago by
 Status changed from positive_review to needs_work
On Ubuntu 16 32bit:
********************************************************************** File "src/sage/modular/modform_hecketriangle/graded_ring_element.py", line 1947, in sage.modular.modform_hecketriangle.graded_ring_element.?.evaluate Failed example: f_i(i + 1e1000) # rel tol 1e3 Expected: 5.96189764223709e14  4.10147008296517e1000*I Got: 6.08402217494586e14  4.10147008296517e1000*I Tolerance exceeded in 1 of 2: 5.96189764223709e14 vs 6.08402217494586e14, tolerance 2e02 > 1e03 ********************************************************************** 1 item had failures: 1 of 132 in sage.modular.modform_hecketriangle.graded_ring_element.?.evaluate [671 tests, 1 failure, 40.96 s]
comment:15 followup: ↓ 18 Changed 18 months ago by
So you see how useless the test is in this form. I'm replacing it with my version.
comment:16 Changed 18 months ago by
 Branch changed from u/jdemeyer/upgrade_to_pynac_0_7_15 to u/rws/24497
comment:17 Changed 18 months ago by
 Commit changed from 70275ab3f3d45469522f3fd75a37a5550727aa0c to 7754ab0868d8efedb668c0c677dd1b9ad415c3fe
 Status changed from needs_work to positive_review
comment:18 in reply to: ↑ 15 Changed 18 months ago by
 Status changed from positive_review to needs_work
Replying to rws:
So you see how useless the test is in this form. I'm replacing it with my version.
Not useless. We just need to increase the tolerance.
comment:19 Changed 18 months ago by
 Branch changed from u/rws/24497 to u/rws/244971
comment:20 Changed 18 months ago by
 Commit changed from 7754ab0868d8efedb668c0c677dd1b9ad415c3fe to d085587a0f4319f03a830c39eb5b3d83836f18dd
 Status changed from needs_work to positive_review
New commits:
d085587  24497: doctest fixes

comment:21 Changed 18 months ago by
 Branch changed from u/rws/244971 to d085587a0f4319f03a830c39eb5b3d83836f18dd
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
24497: pkg version/chksum
24497: doctest fixes