Opened 4 years ago

Closed 4 years ago

#24488 closed defect (fixed)

Iceland lost from the world

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-8.2
Component: graph theory Keywords:
Cc: amyglen Merged in:
Authors: Jori Mäntysalo Reviewers: Jeroen Demeyer, David Coudert
Report Upstream: N/A Work issues:
Branch: f8da95e (Commits, GitHub, GitLab) Commit: f8da95ec78f963f0a3d13be9b481b04a504b56b4
Dependencies: Stopgaps:

Status badges

Description

'Iceland' in graphs.WorldMap() returns False.

(Actually the same applies to Bahrain, for example.)

Change History (8)

comment:1 Changed 4 years ago by jmantysalo

  • Branch set to u/jmantysalo/iceland_lost_from_the_world

comment:2 follow-up: Changed 4 years ago by jmantysalo

  • Commit set to f8da95ec78f963f0a3d13be9b481b04a504b56b4
  • Status changed from new to needs_review

New commits:

f8da95ePut Iceland back to the world.

comment:3 in reply to: ↑ 2 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

Replying to jmantysalo:

Put Iceland back to the world.

That must be one the funniest commit messages.

positive_review if doctests pass and you add your name as author.

comment:4 Changed 4 years ago by jmantysalo

  • Authors set to Jori Mäntysalo

comment:5 Changed 4 years ago by dcoudert

  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, David Coudert
  • Status changed from needs_review to positive_review

Passes all tests on my computer.

comment:6 follow-up: Changed 4 years ago by dcoudert

Actually, Malta was also missing. Now it is back.

comment:7 in reply to: ↑ 6 Changed 4 years ago by jmantysalo

Replying to dcoudert:

Actually, Malta was also missing. Now it is back.

All countries without land border to another country were missing.

(But it's not so fun to have commit message "Put Iceland, Malta, Bahrain and many others back to the world.")

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jmantysalo/iceland_lost_from_the_world to f8da95ec78f963f0a3d13be9b481b04a504b56b4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.