Opened 2 years ago

Closed 2 years ago

#24486 closed enhancement (fixed)

get rid of CombinatorialClass in Restricted Growth Arrays

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3cf9253 (Commits) Commit: 3cf9253bc17d2225738e41e8d991734a1aaf2751
Dependencies: Stopgaps:

Description (last modified by tscrim)

part of #12913

Change History (6)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/24486
  • Commit set to e114e40d493955916160c6e97d6fe2d0d2751186
  • Status changed from new to needs_review

New commits:

​e114e40get rid of CombinatorialClass in Restricted Growth Arrays

comment:2 Changed 2 years ago by tscrim

  • Description modified (diff)
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM (although this is really a shell of a class).

comment:3 Changed 2 years ago by mantepse 

# Seach for maximum i with a[i] != m[i]

should be 

# search for maximum i with a[i] != m[i]

comment:4 Changed 2 years ago by git

  • Commit changed from e114e40d493955916160c6e97d6fe2d0d2751186 to 3cf9253bc17d2225738e41e8d991734a1aaf2751
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​3cf9253typo

comment:5 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

typo corrected, setting back to positive

comment:6 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/24486 to 3cf9253bc17d2225738e41e8d991734a1aaf2751
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.