Opened 2 years ago
Last modified 23 months ago
#24483 needs_work enhancement
complex_field.py complex_number.pyx > complex_mpfr.pyx
Reported by:  vdelecroix  Owned by:  

Priority:  major  Milestone:  sage8.2 
Component:  basic arithmetic  Keywords:  
Cc:  Merged in:  
Authors:  Vincent Delecroix  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/rws/24483 (Commits)  Commit:  aefb4dff3c33aa3e9378f0eb33e90070e03b44dd 
Dependencies:  #24497, #22928  Stopgaps: 
Description (last modified by )
Change History (26)
comment:1 Changed 2 years ago by
 Description modified (diff)
 Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.
comment:2 Changed 2 years ago by
 Branch set to u/vdelecroix/24483
 Commit set to 31c7e6772e34335c149ddc3bca58540772cc3038
 Status changed from new to needs_review
comment:4 Changed 2 years ago by
 Commit changed from 31c7e6772e34335c149ddc3bca58540772cc3038 to aaab91ca3aa64742917b3e375d68c71b5adec850
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
aaab91c  24483: patch for pynac

comment:5 Changed 2 years ago by
 Commit changed from aaab91ca3aa64742917b3e375d68c71b5adec850 to f69c629b28dd1bfa0f04ac4aa0fbf3b5f1bb40ff
comment:6 Changed 2 years ago by
 Description modified (diff)
comment:7 Changed 2 years ago by
 Description modified (diff)
comment:8 Changed 2 years ago by
 Description modified (diff)
comment:9 followup: ↓ 10 Changed 2 years ago by
Can we just do the renaming without deprecation for now? That way, we wouldn't need the fix the Pynac. If possible, I would like to avoid Sagespecific patches to upstream projects.
comment:10 in reply to: ↑ 9 Changed 2 years ago by
Replying to jdemeyer:
Can we just do the renaming without deprecation for now? That way, we wouldn't need the fix the Pynac. If possible, I would like to avoid Sagespecific patches to upstream projects.
The whole point is precisely to start a deprecation... though for ease of review I can move the deprecation in another ticket. Would that be better?
comment:11 Changed 2 years ago by
 Commit changed from f69c629b28dd1bfa0f04ac4aa0fbf3b5f1bb40ff to 74b6eab99a287cc2968e9670b8df3a7efc582d9c
comment:12 Changed 2 years ago by
All right. The import of ComplexField
from sage.rings.complex_field
is not deprecated anymore...
comment:13 Changed 2 years ago by
 Description modified (diff)
comment:14 Changed 2 years ago by
 Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.
comment:15 Changed 2 years ago by
 Dependencies set to #24497
 Report Upstream changed from Fixed upstream, in a later stable release. to N/A
comment:16 Changed 2 years ago by
 Status changed from needs_review to needs_work
Great! Thanks Ralf. I will put back the deprecation.
comment:17 Changed 2 years ago by
 Commit changed from 74b6eab99a287cc2968e9670b8df3a7efc582d9c to 14c9753e43f16686597e4a239b190472fd19ef90
comment:18 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:19 Changed 2 years ago by
 Status changed from needs_review to needs_work
a lot of doctest failures...
comment:20 Changed 2 years ago by
 Description modified (diff)
comment:21 Changed 2 years ago by
 Status changed from needs_work to needs_review
Actually these are failing because the patchbot is not merging #24497 first!
comment:22 Changed 2 years ago by
 Dependencies changed from #24497 to #24497, #22928
 Status changed from needs_review to needs_work
comment:23 Changed 2 years ago by
 Description modified (diff)
comment:24 Changed 2 years ago by
 Branch changed from u/vdelecroix/24483 to u/rws/24483
comment:25 Changed 2 years ago by
 Commit changed from 14c9753e43f16686597e4a239b190472fd19ef90 to aefb4dff3c33aa3e9378f0eb33e90070e03b44dd
 Status changed from needs_work to needs_review
comment:26 Changed 23 months ago by
 Status changed from needs_review to needs_work
Got one doctest failure
sage t src/sage/misc/citation.pyx ********************************************************************** File "src/sage/misc/citation.pyx", line 87, in sage.misc.citation.get_systems Failed example: get_systems('((a+1)^2).expand()') Expected: ['MPFR', 'ginac'] Got: ['ginac'] ********************************************************************** 1 item had failures: 1 of 11 in sage.misc.citation.get_systems [13 tests, 1 failure, 1.75 s]
Let us see about doctests
New commits:
24483: merge complex_number/complex_field into complex_mpfr
24483: fix interpreters
24483: fix imports
24483: patch for pynac