Opened 3 years ago

Closed 3 years ago

#24476 closed enhancement (fixed)

Support downloading of symlinked tarballs

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.2
Component: build Keywords:
Cc: embray, vbraun, fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 5b8e8dd (Commits) Commit: 5b8e8ddf7a67bd062fa67c89d2b140b4846549d4
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

#12426 introduces a new package "gfortran" which reuses the gcc tarball. This is done by symlinking various files in build/pkgs/gfortran to build/pkgs/gcc. This confuses the tarball downloader, so we add support for such symlinks in sage_bootstrap.

Change History (14)

comment:1 Changed 3 years ago by jdemeyer

  • Summary changed from Properly download symlinked tarballs to Support downloading of symlinked tarballs

comment:2 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/support_downloading_of_symlinked_tarballs

comment:3 Changed 3 years ago by jdemeyer

  • Commit set to 5b8e8ddf7a67bd062fa67c89d2b140b4846549d4
  • Status changed from new to needs_review

New commits:

​5b8e8ddSupport downloading of symlinked tarballs

comment:4 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 3 years ago by jdemeyer

  • Cc embray vbraun added

comment:6 Changed 3 years ago by fbissey

  • Cc fbissey added

comment:7 follow-up: Changed 3 years ago by vbraun

So whats the plan, have a symlinked tarball or two packages refer to the same tarball? The latter seems more sane to me. Whereas the former raises some questions, e.g. what to upload to mirrors.

Looking up tarball name -> package name isn't really important I think. Could just return a set of matching packages.

comment:8 Changed 3 years ago by fbissey

Two packages referring to the same tarball. In #12426 I ended up creating a spkg for gfortran which of course uses gcc's tarball.

comment:9 in reply to: ↑ 7 Changed 3 years ago by jdemeyer

Replying to vbraun:

Looking up tarball name -> package name isn't really important I think.

It is needed because the tarballs on the server are stored per package. The URL is something like .../spkg/upstream/gcc/gcc-7.2.0.xz, where gcc is the package name.

comment:10 follow-up: Changed 3 years ago by dimpase

I am testing this together with #12426. If this is the only scenario to consider, this looks good. Should then #12426 become a dependence here?

comment:11 in reply to: ↑ 10 Changed 3 years ago by jdemeyer

Replying to dimpase:

Should then #12426 become a dependence here?

No. Why should it be?

comment:12 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik

looks good to me.

comment:13 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

comment:14 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/support_downloading_of_symlinked_tarballs to 5b8e8ddf7a67bd062fa67c89d2b140b4846549d4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.