Opened 4 years ago

Closed 4 years ago

#24450 closed enhancement (fixed)

BruhatTitsTree.lift: bail out if matrix is not invertible

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.2
Component: modular forms Keywords:
Cc: mmasdeu, roed Merged in:
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: d61f9ea (Commits, GitHub, GitLab) Commit: d61f9ea30608521b19f1960cfeba9ace61adb51f
Dependencies: Stopgaps:

Status badges

Description

If the determinant of the matrix is zero, the code does some very dubious things which happen to fail in the right way mostly by accident. This happens to break #24247, but it's clear that checking for a zero determinant makes sense anyway.

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/24450

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to d61f9ea30608521b19f1960cfeba9ace61adb51f
  • Status changed from new to needs_review

New commits:

​d61f9eaBruhatTitsTree.lift: bail out if matrix is not invertible

comment:3 Changed 4 years ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

Looks good to me.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/24450 to d61f9ea30608521b19f1960cfeba9ace61adb51f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.