Opened 13 years ago

Closed 13 years ago

#2445 closed defect (fixed)

[with patch, positive review] algebras module lacks many docstrings and tests (score 15.7%)

Reported by: cremona Owned by: malb
Priority: major Milestone: sage-2.10.3
Component: commutative algebra Keywords: algebras modules
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Most files in sage/algebras have little or no docstrings and almost no doctests. This patch makes a start on remedying this, but there is a lot more to be done.

Attachments (2)

8821.patch (11.3 KB) - added by cremona 13 years ago.
trac_8821.patch (565 bytes) - added by gfurnish 13 years ago.
Fix for trivial algebra.py failure

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by cremona

comment:1 Changed 13 years ago by cremona

  • Summary changed from algebras module lacks many docstrings and tests (score 15.7%) to [with patch, needs review] algebras module lacks many docstrings and tests (score 15.7%)

comment:2 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.0 to sage-2.10.3

comment:3 Changed 13 years ago by gfurnish

  • Summary changed from [with patch, needs review] algebras module lacks many docstrings and tests (score 15.7%) to [with patch, with negative review] algebras module lacks many docstrings and tests (score 15.7%)

This does not pass sage -t algebra.py

comment:4 Changed 13 years ago by gfurnish

  • Summary changed from [with patch, with negative review] algebras module lacks many docstrings and tests (score 15.7%) to [with patch, positive review pending patch] algebras module lacks many docstrings and tests (score 15.7%)

This just needs a True statement added in the doctest in algebra.py

Changed 13 years ago by gfurnish

Fix for trivial algebra.py failure

comment:5 Changed 13 years ago by gfurnish

  • Summary changed from [with patch, positive review pending patch] algebras module lacks many docstrings and tests (score 15.7%) to [with patch, positive review] algebras module lacks many docstrings and tests (score 15.7%)

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged both patches in Sage 2.10.3.rc4

Note: See TracTickets for help on using tickets.