Opened 4 years ago
Closed 3 years ago
#24432 closed enhancement (fixed)
let category handles is_field/is_finite/cardinality for many rings
Reported by:  vdelecroix  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  algebra  Keywords:  
Cc:  chapoton  Merged in:  
Authors:  Vincent Delecroix, Frédéric Chapoton  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  e9a6e2b (Commits, GitHub, GitLab)  Commit:  e9a6e2bf9ddd1af73bfd768eabc2562c624ef9e1 
Dependencies:  Stopgaps: 
Description (last modified by )
Change History (22)
comment:1 Changed 4 years ago by
 Description modified (diff)
 Summary changed from let category handles is_finite/cardinality for rings to let category handles is_field/is_finite/cardinality for many rings
comment:2 Changed 4 years ago by
 Branch set to u/vdelecroix/24432
 Commit set to 1dca25bf8309a1c90a38d4e48e4ecbee9f885cc6
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Commit changed from 1dca25bf8309a1c90a38d4e48e4ecbee9f885cc6 to fe161a625ee45847f5c9387b7a6cbf287312222a
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
fe161a6  24432: is_field/is_finite/cardinality

comment:4 Changed 4 years ago by
 Dependencies set to #24413
comment:5 Changed 4 years ago by
 Status changed from needs_review to needs_work
comment:6 Changed 4 years ago by
 Description modified (diff)
comment:7 Changed 4 years ago by
 Commit changed from fe161a625ee45847f5c9387b7a6cbf287312222a to 16ab37b31fb0b10fb25eb13781bd48a76718fdfb
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
f95f61e  24413: make polynomial rings know that they are infinite

c905ee9  24413: base ring = 0

365ede1  trac 24413 doc details

984e2df  24432: is_field/is_finite/cardinality

16ab37b  24432: number fields not infinite by default

comment:8 Changed 4 years ago by
see #23418
comment:9 Changed 4 years ago by
 Dependencies changed from #24413 to #24413, #23418
 Description modified (diff)
comment:10 Changed 3 years ago by
 Branch changed from u/vdelecroix/24432 to u/saraedum/24432
comment:11 Changed 3 years ago by
 Commit changed from 16ab37b31fb0b10fb25eb13781bd48a76718fdfb to ccd834e454490cc30c59fe2e571f4d7a1a429c0b
 Status changed from needs_work to needs_info
I tried to rebase this on top of develop. I hope I didn't screw up in some way.
What's the status of this now? Does this essentially need review?
New commits:
ccd834e  Merge develop and 24432

comment:12 Changed 3 years ago by
Some update is needed. For example the following make no sense
_NumberFields = NumberFields() +# even though number fields are infinite, it seems delicate +# to have it automatically understood by the category +# see https://groups.google.com/forum/#!topic/sagedevel/ZtXuXan6cg +_NumberFields = NumberFields().Infinite()
as
sage: NumberFields() is NumberFields().Infinite() True
comment:13 Changed 3 years ago by
 Branch changed from u/saraedum/24432 to public/ticket/24432
 Commit changed from ccd834e454490cc30c59fe2e571f4d7a1a429c0b to 16a1674d8e6bbf127656aab04788bb87a0460f9e
 Dependencies #24413, #23418 deleted
comment:14 Changed 3 years ago by
 Milestone changed from sage8.2 to sage8.7
comment:15 Changed 3 years ago by
 Commit changed from 16a1674d8e6bbf127656aab04788bb87a0460f9e to 1d0f9d3be6f7a9223f68cf613139c68d81477dee
Branch pushed to git repo; I updated commit sha1. New commits:
1d0f9d3  trac 24432 tiny fix

comment:16 Changed 3 years ago by
 Commit changed from 1d0f9d3be6f7a9223f68cf613139c68d81477dee to aca09f85623b99c8e071264907a6ee4531e2a899
Branch pushed to git repo; I updated commit sha1. New commits:
aca09f8  trac 24432 another tiny fix

comment:17 Changed 3 years ago by
 Status changed from needs_info to needs_review
comment:18 Changed 3 years ago by
 Commit changed from aca09f85623b99c8e071264907a6ee4531e2a899 to e7d82f0f10de342ec232c48ebe38624cdd57c609
Branch pushed to git repo; I updated commit sha1. New commits:
e7d82f0  trac 24432 removed unused import

comment:19 Changed 3 years ago by
 Commit changed from e7d82f0f10de342ec232c48ebe38624cdd57c609 to e9a6e2bf9ddd1af73bfd768eabc2562c624ef9e1
Branch pushed to git repo; I updated commit sha1. New commits:
e9a6e2b  trac 24432 fix one doctest

comment:20 Changed 3 years ago by
This should be ready to go. Can somebody else please confirm ?
comment:21 Changed 3 years ago by
 Reviewers set to Vincent Delecroix
 Status changed from needs_review to positive_review
This is ok. Thank you.
comment:22 Changed 3 years ago by
 Branch changed from public/ticket/24432 to e9a6e2bf9ddd1af73bfd768eabc2562c624ef9e1
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
24432: is_field/is_finite/cardinality