Changes between Version 8 and Version 13 of Ticket #24431


Ignore:
Timestamp:
Jan 3, 2018, 4:56:02 PM (5 years ago)
Author:
tscrim
Comment:

I understand now the reason why that change is needed. Thanks. (Although I don't quite understand why that pushout is no longer allowed, but that's okay.)

Just remove the unneeded import of LaurentPolynomialRing and the \'s here

@@ -410,7 +565,11 @@ class LaurentSeriesRing_generic(UniqueRepresentation, ring.CommutativeRing):
 
         from sage.rings.polynomial.polynomial_ring import is_PolynomialRing
         from sage.rings.power_series_ring import is_PowerSeriesRing
-        if ((is_LaurentSeriesRing(P) or is_PowerSeriesRing(P) or is_PolynomialRing(P))
+        from sage.rings.polynomial.laurent_polynomial_ring import is_LaurentPolynomialRing
+        if ((is_LaurentSeriesRing(P) or \
+             is_LaurentPolynomialRing(P) or \
+             is_PowerSeriesRing(P) or \
+             is_PolynomialRing(P))
             and P.variable_name() == self.variable_name()
             and A.has_coerce_map_from(P.base_ring())):
             return True

and you can set a positive review on my behalf.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24431

    • Property Reviewers changed from to Travis Scrimshaw
    • Property Commit changed from 1b1bbbc062f24af9adecd11ddab5a12bf8812636 to b3f11d9d244e72085a96d64e1286aa43f70df44f
  • Ticket #24431 – Description

    v8 v13  
    1717}}}
    1818
    19 There are also wrong coercions going on
     19Currently, these pushouts are allowed:
    2020{{{
    2121sage: x = LaurentSeriesRing(QQ, 'x').gen()
     
    2727Laurent Series Ring in x over Rational Field
    2828}}}
     29This is inconsistent with `PowerSeriesRing`.
    2930
    30 By fixing these problems, we had to adapt some code in `sage/schemes/hyperelliptic_curves/hyperelliptic_generic.py` that used to benefit from this buggy behavior.
     31By fixing these problems, we had to adapt some code in `sage/schemes/hyperelliptic_curves/hyperelliptic_generic.py` that was using the aforementioned pushout.