Opened 3 years ago

Closed 2 years ago

#24427 closed enhancement (wontfix)

Upgrade to GAP 4.8.10

Reported by: slelievre Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: GAP, database_gap, gap_packages, libgap
Cc: dimpase, fbissey, jdemeyer, slelievre, vbraun, gh-timokau, gh-sebasguts, nthiery, embray Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

GAP 4.8.10 was released on 2018-01-15.

Release announcement:

GAP 4.8.10 page:

Changelog:

From SageMath 7.6.beta3 to the current SageMath 8.2.beta3, we use GAP 4.8.6, introduced in #20914. Time to upgrade!

Tarball for GAP:

Tarballs for database_gap, gap_packages, libgap:

Note that #22626 will upgrade to the upcoming GAP 4.9, but it would be nice to upgrade to GAP 4.8.10 for now.

Attachments (1)

gap-4.8.10.tar.bz2 (10.4 MB) - added by nthiery 3 years ago.
gap 4.8.10 sources after running spkg-src

Change History (22)

comment:1 Changed 3 years ago by slelievre

  • Cc slelievre added
  • Description modified (diff)
  • Summary changed from Upgrade to GAP 4.8.9 to Upgrade to GAP 4.8.10

Changing the goal of this ticket from "GAP 4.8.9" to "GAP 4.8.10".

comment:2 Changed 3 years ago by dimpase

comment:3 Changed 3 years ago by slelievre

I suggest getting GAP 4.8.10 in Sage 8.2, if it's not too much work, since:

  • GAP 4.9 might still be in beta when Sage 8.2 is released.
  • GAP 4.9 has major changes, so #22626 (Upgrade to GAP 4.9) might take time.

comment:4 follow-up: Changed 3 years ago by slelievre

  • Type changed from PLEASE CHANGE to enhancement

Although the release of GAP 4.9.1 is approaching, I don't know if it will still be a beta or considered the official 4.9 release.

It might still be possible to get GAP 4.8.10 in Sage 8.2. What are the steps to produce tarballs for database_gap, gap_packages, libgap?

comment:5 in reply to: ↑ 4 ; follow-up: Changed 3 years ago by dimpase

Replying to slelievre:

Although the release of GAP 4.9.1 is approaching, I don't know if it will still be a beta or considered the official 4.9 release.

It might still be possible to get GAP 4.8.10 in Sage 8.2. What are the steps to produce tarballs for database_gap, gap_packages, libgap?

Updating libgap is potentially time-consuming and error-prone. See https://bitbucket.org/vbraun/libgap

comment:6 in reply to: ↑ 5 Changed 3 years ago by slelievre

Replying to dimpase:

Replying to slelievre:

Although the release of GAP 4.9.1 is approaching, I don't know if it will still be a beta or considered the official 4.9 release.

It might still be possible to get GAP 4.8.10 in Sage 8.2. What are the steps to produce tarballs for database_gap, gap_packages, libgap?

Updating libgap is potentially time-consuming and error-prone. See https://bitbucket.org/vbraun/libgap

Hard to know in advance, but one might hope that minor version bumps in GAP would be relatively easy to deal with.

The upgrade to GAP 4.8.10 in the ArchLinux packaging of SageMath seems pretty straightforward:

https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/libgap#n20

comment:7 Changed 3 years ago by dimpase

This looks fishy - just version bumps...

comment:8 Changed 3 years ago by jdemeyer

Worse than fishy: plain wrong!

It looks like they took the 4.8.6 tarball and artificially renamed it 4.8.10.

comment:9 follow-up: Changed 3 years ago by slelievre

In Debian they use GAP 4.8.8, does that mean they produced libgap for 4.8.8?

comment:10 in reply to: ↑ 9 Changed 3 years ago by dimpase

Replying to slelievre:

In Debian they use GAP 4.8.8, does that mean they produced libgap for 4.8.8?

Probably they did. Last time I worked on upgrade to 4.8.6, I used Debian's work, IIRC.

Changed 3 years ago by nthiery

gap 4.8.10 sources after running spkg-src

comment:11 Changed 3 years ago by nthiery

  • Branch set to u/nthiery/upgrade_to_gap_4_8_10

comment:12 Changed 3 years ago by nthiery

  • Commit set to a543971fa359d9a5cd7009935c1a24de39e9601c

To get the ball rolling, I updated the GAP sources according to the instructions in the SPKG. I haven't run the tests yet (rebuilding my Sage).


New commits:

3c56a1b24427: Upgrade to gap 4.8.10, first step: upgrade the sources
a54397124427: expanded upgrade instructions for gap's spkg

comment:13 Changed 3 years ago by tscrim

Just noting #13426, which adds more things to gap_packages.

comment:14 Changed 3 years ago by slelievre

  • Description modified (diff)

Sebastian Gutsche produced a tentative tarball for libgap-4.8.10: https://bitbucket.org/sebasguts/libgap/downloads/libgap-4.8.10.tar.gz

comment:15 Changed 3 years ago by fbissey

We should note that the only thing changing since 4.8.8 is the packages distributed with gap. https://www.gap-system.org/Manuals/doc/changes/chap2.html#X803A9F0685295E01

Core gap code and databases have not changed since 4.8.8. The libgap for 4.8.8 that debian made should be identical for 4.8.10.

comment:16 follow-up: Changed 3 years ago by nthiery

Thanks François for the info.

The branch as is is not yet functional, as libgap needs to be the same version as gap. Sebastian's libgap above is missing the prefixing; he will work on this tonight, and then I'll update this branch and rerun the tests.

comment:17 Changed 3 years ago by gh-timokau

  • Cc gh-timokau added

comment:18 in reply to: ↑ 16 Changed 3 years ago by slelievre

  • Cc gh-sebasguts nthiery added
  • Milestone changed from sage-8.2 to sage-8.4

Replying to nthiery:

The branch as is is not yet functional, as libgap needs to be the same version as gap. Sebastian's libgap above is missing the prefixing; he will work on this tonight, and then I'll update this branch and rerun the tests.

Did the prefixing happen in the end? What remains to be done here?

comment:19 Changed 2 years ago by chapoton

  • Cc embray added
  • Milestone changed from sage-8.4 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

can we close this one now ?

comment:20 Changed 2 years ago by tscrim

  • Branch u/nthiery/upgrade_to_gap_4_8_10 deleted
  • Commit a543971fa359d9a5cd7009935c1a24de39e9601c deleted
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I believe so.

comment:21 Changed 2 years ago by embray

  • Resolution set to wontfix
  • Status changed from positive_review to closed

Superseded by #22626.

Note: See TracTickets for help on using tickets.