Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#24426 closed defect (fixed)

Fricas doctest failure

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.2
Component: doctest coverage Keywords:
Cc: mantepse, rws Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4eee0ea (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

The following happens on all patchbots which have fricas installed: 

sage -t --long src/sage/interfaces/fricas.py
**********************************************************************
File "src/sage/interfaces/fricas.py", line 1097, in sage.interfaces.fricas.FriCASElement._sage_expression
Failed example:
    [f(x)._fricas_().sage().subs(x=0.9) for f in l]               # optional - fricas
Expected:
    [0.716297870199024,
     1.02651672570818,
     1.43308638544877,
     1.39606725303001,
     0.697794641100332,
     0.974168247780004,
     0.808866935652782,
     NaN,
     1.47221948958322,
     NaN,
     0.467145308103262,
     0.957800449200672,
     0.808866935652782,
     NaN,
     1.47221948958322,
     NaN,
     0.467145308103262,
     0.957800449200672]
Got:
    [0.716297870199024,
     1.02651672570818,
     1.43308638544877,
     1.39606725303001,
     0.697794641100332,
     0.974168247780004,
     0.808866935652782,
     0.451026811796262*I,
     1.47221948958322,
     1.47221948958322,
     0.467145308103262,
     0.957800449200672,
     0.808866935652782,
     0.451026811796262*I,
     1.47221948958322,
     1.47221948958322,
     0.467145308103262,
     0.957800449200672]
**********************************************************************

Change History (8)

comment:1 Changed 3 years ago by mantepse

I can confirm this, but it doesn't have anything to do with fricas: 

sage: arccoth(0.9)
NaN
sage: arccoth(x).subs(x=0.9)
1.47221948958322
sage: version()
'SageMath version 8.2.beta1, Release Date: 2017-12-22'

comment:2 Changed 3 years ago by jdemeyer

OK. I created #24428 for the underlying issue. On this ticket, we can just fix the doctests.

comment:3 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/fricas_doctest_failure

comment:4 Changed 3 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 4eee0eadf99a37ade97459a809e47a47b784c0b4
  • Component changed from packages: optional to doctest coverage
  • Status changed from new to needs_review

New commits:

​4eee0eaFix optional doctest failures

comment:5 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:6 Changed 3 years ago by mantepse

That's a strange fix, I must say. At the same time, I do agree that it is only by luck the failure occurs in the FriCAS interface code and nowhere else.

Would you agree to make #24428 a blocker?

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/fricas_doctest_failure to 4eee0eadf99a37ade97459a809e47a47b784c0b4
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 3 years ago by vdelecroix

  • Commit 4eee0eadf99a37ade97459a809e47a47b784c0b4 deleted

Same doctest failing again on 8.2.beta6 on quasar 

sage -t --long src/sage/interfaces/fricas.py
**********************************************************************
File "src/sage/interfaces/fricas.py", line 1096, in sage.interfaces.fricas.FriCASElement._sage_expression
Failed example:
    [f(x)._fricas_().sage().subs(x=0.9) for f in l]               # optional - fricas
Expected:
    [0.716297870199024,
     1.02651672570818,
     1.43308638544877,
     1.39606725303001,
     0.697794641100332,
     0.974168247780004,
     0.808866935652782,
     0.451026811796262*I,
     1.47221948958322,
     1.47221948958322,
     0.467145308103262,
     0.957800449200672,
     0.808866935652782,
     0.451026811796262*I,
     1.47221948958322,
     1.47221948958322,
     0.467145308103262,
     0.957800449200672]
Got:
    [0.716297870199024,
     1.02651672570818,
     1.43308638544877,
     1.39606725303001,
     0.697794641100332,
     0.974168247780004,
     0.808866935652782,
     0.451026811796262*I,
     1.47221948958322,
     1.47221948958322 - 1.57079632679490*I,
     0.467145308103262,
     0.957800449200672,
     0.808866935652782,
     0.451026811796262*I,
     1.47221948958322,
     1.47221948958322 - 1.57079632679490*I,
     0.467145308103262,
     0.957800449200672]
**********************************************************************
1 item had failures:
   1 of  10 in sage.interfaces.fricas.FriCASElement._sage_expression
    [173 tests, 1 failure, 31.46 s]
Note: See TracTickets for help on using tickets.