Opened 4 years ago
Closed 4 years ago
#24424 closed defect (fixed)
Dancing links random failures
Reported by: | vbraun | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.2 |
Component: | combinatorics | Keywords: | random_fail |
Cc: | slabbe, vdelecroix | Merged in: | |
Authors: | Sébastien Labbé | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | 2df8c97 (Commits, GitHub, GitLab) | Commit: | 2df8c973e4b7f0c0ced1d45ecf3f2a273d971892 |
Dependencies: | Stopgaps: |
Description
The output of one_solution
is random:
********************************************************************** File "src/sage/combinat/matrices/dancing_links.pyx", line 27, in sage.combinat.matrices.dancing_links Failed example: sorted(x.one_solution(ncpus=8)) Expected: [0, 1] Got: [2, 3] ********************************************************************** 1 item had failures: 1 of 20 in sage.combinat.matrices.dancing_links [175 tests, 1 failure, 8.38 s] ---------------------------------------------------------------------- sage -t --long src/sage/combinat/matrices/dancing_links.pyx # 1 doctest failed ----------------------------------------------------------------------
Also, does ncpus=8 really use 8 cores? We already parallelize doctests! Tests should definitely not x8 that.
Change History (6)
comment:1 Changed 4 years ago by
- Branch set to u/slabbe/24424
- Commit set to 2df8c973e4b7f0c0ced1d45ecf3f2a273d971892
comment:2 Changed 4 years ago by
- Status changed from new to needs_review
comment:3 in reply to: ↑ description Changed 4 years ago by
Replying to vbraun:
Also, does ncpus=8 really use 8 cores? We already parallelize doctests! Tests should definitely not x8 that.
I changed 8 to 2. The dancing links problem in question uses only 6 rows. So, it is not something that will use a lot of cpu time (something like 1ms).
comment:4 Changed 4 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
comment:5 Changed 4 years ago by
comment:6 Changed 4 years ago by
- Branch changed from u/slabbe/24424 to 2df8c973e4b7f0c0ced1d45ecf3f2a273d971892
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
24424: fixing random doctests failures