Opened 4 years ago
Closed 4 years ago
#24413 closed enhancement (fixed)
make polynomial rings know that they are infinite
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.2 
Component:  algebra  Keywords:  
Cc:  vdelecroix  Merged in:  
Authors:  Frédéric Chapoton, Vincent Delecroix  Reviewers:  Vincent Delecroix, Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  2b06fd7 (Commits, GitHub, GitLab)  Commit:  2b06fd76b8889ea51f0a5dae301cbe757c326ce4 
Dependencies:  #24408  Stopgaps: 
Description (last modified by )
so that their fraction fields also know that
Followup: #24432
Change History (20)
comment:1 Changed 4 years ago by
 Branch set to u/chapoton/24413
 Commit set to 4662e81cbb18adb4a0173135f2236025d00d7d34
comment:2 Changed 4 years ago by
 Commit changed from 4662e81cbb18adb4a0173135f2236025d00d7d34 to 2591d309c080823fa97f106d1691de4a6929dcc5
Branch pushed to git repo; I updated commit sha1. New commits:
2591d30  trac 24413 doc detail

comment:3 Changed 4 years ago by
needs review?
comment:4 followup: ↓ 5 Changed 4 years ago by
Also, how much do you want do deal with the corner case of n = 0
here?
comment:5 in reply to: ↑ 4 Changed 4 years ago by
Replying to tscrim:
Also, how much do you want do deal with the corner case of
n = 0
here?
And the case of the zero ring (ie Zmod(1)
) for which the polynomial ring only consists of 0
. The arguments of polynomial_default_category
are not enough to detect this.
comment:6 Changed 4 years ago by
 Branch changed from u/chapoton/24413 to public/24413
 Commit changed from 2591d309c080823fa97f106d1691de4a6929dcc5 to d50fd1facdc1e93dac3e1c3906db85b9f0d30ca0
 Description modified (diff)
 Status changed from new to needs_review
comment:7 Changed 4 years ago by
 Commit changed from d50fd1facdc1e93dac3e1c3906db85b9f0d30ca0 to c905ee96cc6f80e679cc55ddaf9e02380e18672b
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
c905ee9  24413: base ring = 0

comment:8 Changed 4 years ago by
 Commit changed from c905ee96cc6f80e679cc55ddaf9e02380e18672b to 365ede1adba4febfc1efdda9d973ea9c303af1b9
Branch pushed to git repo; I updated commit sha1. New commits:
365ede1  trac 24413 doc details

comment:9 Changed 4 years ago by
ok, looks good to me. I made two cosmetic changes in the doc.
Can we set to positive ?
comment:10 Changed 4 years ago by
ok for me if patchbot happy!
comment:11 Changed 4 years ago by
 Reviewers set to Vincent Delecroix, Frédéric Chapoton
 Status changed from needs_review to positive_review
comment:13 Changed 4 years ago by
 Commit changed from 365ede1adba4febfc1efdda9d973ea9c303af1b9 to 0d8602b4c79ab23a46fcc6010fc0c01a3a5f8c50
comment:15 Changed 4 years ago by
my commit from comment:8 is missing
comment:16 Changed 4 years ago by
 Status changed from needs_review to needs_work
comment:17 Changed 4 years ago by
 Commit changed from 0d8602b4c79ab23a46fcc6010fc0c01a3a5f8c50 to 2b06fd76b8889ea51f0a5dae301cbe757c326ce4
Branch pushed to git repo; I updated commit sha1. New commits:
2b06fd7  trac 24413 doc details

comment:20 Changed 4 years ago by
 Branch changed from public/24413 to 2b06fd76b8889ea51f0a5dae301cbe757c326ce4
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
make polynomial rings know that they are infinite