Opened 2 years ago

Closed 23 months ago

Last modified 22 months ago

#24411 closed enhancement (fixed)

Move gamma functions into their own file

Reported by: rws Owned by:
Priority: major Milestone: sage-8.2
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: db535dc (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by rws)

gamma, log_gamma, gamma_inc, gamma_inc_lower, beta, psi are enough of the same kind to justify their own file. It eases pressure on the general other.py file and makes finding their documentation easier.

Change History (14)

comment:1 Changed 2 years ago by rws

  • Branch set to u/rws/move_gamma_functions_into_their_own_file

comment:2 Changed 2 years ago by rws

  • Commit set to b49ea7634d85dde58ec9557fee4cdaf78fc9c02f
  • Description modified (diff)

New commits:

b49ea7624411: move gamma functions to gamma.py

comment:3 Changed 2 years ago by git

  • Commit changed from b49ea7634d85dde58ec9557fee4cdaf78fc9c02f to f87cf6c523f38b4b4d1d4a6c467a67db37a2b75f

Branch pushed to git repo; I updated commit sha1. New commits:

385bba6Merge branch 'develop' into t/24411/move_gamma_functions_into_their_own_file
f87cf6c24411: adapt to pynac-0.7.14

comment:4 Changed 2 years ago by rws

  • Status changed from new to needs_review

comment:5 Changed 2 years ago by tscrim

You will need to add deprecations saying the import locations have moved (lazy_import has an argument to do that). Also, you should add absolute_import to the new file's __future__ import(s). (Personally, I don't like the relative imports as it makes it less explicit, but I don't really care, so don't feel like you need to change/revert.)

comment:6 Changed 2 years ago by git

  • Commit changed from f87cf6c523f38b4b4d1d4a6c467a67db37a2b75f to 1bc73c4a1cbb03f866889a40d4f7958c0328017b

Branch pushed to git repo; I updated commit sha1. New commits:

1bc73c424411: deprecation, imports

comment:7 Changed 2 years ago by vdelecroix

Author? If you don't field the field patchbot will never come.

comment:8 Changed 2 years ago by rws

  • Authors set to Ralf Stephan

comment:9 Changed 23 months ago by rws

  • Status changed from needs_review to needs_work

Tests fail.

comment:10 Changed 23 months ago by git

  • Commit changed from 1bc73c4a1cbb03f866889a40d4f7958c0328017b to db535dc8a50256e8b70708e15d4508f07d8e217a

Branch pushed to git repo; I updated commit sha1. New commits:

fc07c91Merge branch 'develop' into t/24411/move_gamma_functions_into_their_own_file
db535dc24411: more imports changed

comment:11 Changed 23 months ago by rws

  • Status changed from needs_work to needs_review

comment:12 Changed 23 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Patchbot is (morally) green and this is mostly just a big move ticket. Let's hope this doesn't conflict with anything.

comment:13 Changed 23 months ago by vbraun

  • Branch changed from u/rws/move_gamma_functions_into_their_own_file to db535dc8a50256e8b70708e15d4508f07d8e217a
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:14 Changed 22 months ago by chapoton

  • Commit db535dc8a50256e8b70708e15d4508f07d8e217a deleted

follow-up in #24719

Note: See TracTickets for help on using tickets.