Opened 5 years ago

Closed 5 years ago

#24409 closed enhancement (fixed)

py3: remove deprecated cmpfn ; wrap key(..) in multi-polynomials

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.2
Component: python3 Keywords:
Cc: embray, jdemeyer, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: a7dbdff (Commits, GitHub, GitLab) Commit: a7dbdfff5a7cddf5a2ccd698390ab3a870501cad
Dependencies: Stopgaps:

Status badges

Description

as followup of #21766 and part of #16536 and #15981

Change History (9)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/24409
  • Cc embray jdemeyer tscrim added
  • Commit set to 3f46b40ec91afc055294fa012d7780240c675962
  • Status changed from new to needs_review

New commits:

3f46b40py3: get rid of cmpfn to sort polynomials, plus wrap keys(..) with list

comment:2 Changed 5 years ago by chapoton

green bot, please review

comment:3 Changed 5 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 5 years ago by tscrim

The keys call is redundant, so I would actually remove that altogether.

comment:5 Changed 5 years ago by embray

  • Status changed from positive_review to needs_work

Indeed; lines like this

E = list(self.__repn.keys())

can just be written

E = list(self.__repn)

comment:6 Changed 5 years ago by git

  • Commit changed from 3f46b40ec91afc055294fa012d7780240c675962 to a7dbdfff5a7cddf5a2ccd698390ab3a870501cad

Branch pushed to git repo; I updated commit sha1. New commits:

a7dbdfftrac 24409 removing .keys

comment:7 Changed 5 years ago by chapoton

  • Status changed from needs_work to needs_review

done. Needs review

comment:8 Changed 5 years ago by embray

  • Status changed from needs_review to positive_review

comment:9 Changed 5 years ago by vbraun

  • Branch changed from u/chapoton/24409 to a7dbdfff5a7cddf5a2ccd698390ab3a870501cad
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.