Opened 5 years ago
Closed 5 years ago
#24383 closed enhancement (fixed)
py3: remove cmp in words
| Reported by: | chapoton | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.2 |
| Component: | python3 | Keywords: | |
| Cc: | embray | Merged in: | |
| Authors: | Frédéric Chapoton | Reviewers: | Erik Bray |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 5612606 (Commits, GitHub, GitLab) | Commit: | 5612606d4c3fc1cde6ebc5169023197f3f2d7d5e |
| Dependencies: | Stopgaps: |
Status badges
Description
plus some deprecated stuff
Change History (10)
comment:1 Changed 5 years ago by
- Branch set to u/chapoton/24383
- Commit set to e7c657813d470509c9405f1ee4f236265cd21edf
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
I don't know what the Sage policy is on how long something can be marked "Deprecated" before it's removed, or even if it's ever removed at all. But +1 in principle.
comment:3 Changed 5 years ago by
One year deprecation is the official policy.
comment:4 Changed 5 years ago by
There's a little text file src/sage/combinat/words/notes/word_inheritance_howto.txt dating back to around when this module was first added, and that I think is just kind of free-floating. If there's anything of value in it, those bits should be moved into the actual module documentation. Otherwise it can probably be removed (it references some of the interfaces removed here).
comment:5 Changed 5 years ago by
- Commit changed from e7c657813d470509c9405f1ee4f236265cd21edf to 5612606d4c3fc1cde6ebc5169023197f3f2d7d5e
Branch pushed to git repo; I updated commit sha1. New commits:
| 5612606 | trac 24383 turning a "notes" file to rst
|
comment:6 Changed 5 years ago by
I have just changed this file a little bit (removing references to what was deprecated and is being removed) and turned it into rst. No idea if it still make any sense.
comment:7 Changed 5 years ago by
- Status changed from needs_review to positive_review
Okay, we can worry about what to do about that file, if anything, separately then.
comment:8 Changed 5 years ago by
- Status changed from positive_review to needs_work
Reviewer name is missing...
comment:9 Changed 5 years ago by
- Reviewers set to Erik Bray
- Status changed from needs_work to positive_review
comment:10 Changed 5 years ago by
- Branch changed from u/chapoton/24383 to 5612606d4c3fc1cde6ebc5169023197f3f2d7d5e
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
remove deprecated stuff in words, including a cmp