Opened 5 years ago

Closed 5 years ago

#24381 closed enhancement (fixed)

New Parent method _convert_method_map

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-8.2
Component: coercion Keywords:
Cc: Vincent Delecroix, Travis Scrimshaw Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 18d9877 (Commits, GitHub, GitLab) Commit: 18d98778238982fd01f7cc9a1f027aff51460305
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Factor out the logic to determine a NamedConvertMap in _generic_convert_map. This way, it can be used by _coerce_map_from_ methods.

Also clean up the logic in discover_coerce_map_from a bit and remove the unused force_use flag from DefaultConvertMap and NamedConvertMap.

Change History (18)

comment:1 Changed 5 years ago by Jeroen Demeyer

Branch: u/jdemeyer/new_parent_method__convert_method_map

comment:2 Changed 5 years ago by Jeroen Demeyer

Commit: cf2f643c766b42094c2a403f9c4a27ae3f11d5c3
Summary: New Parent method _convert_method_map_convert_method_name should take priority as conversion

New commits:

cf2f643New Parent method _convert_method_map

comment:3 Changed 5 years ago by Jeroen Demeyer

Cc: Simon King added
Description: modified (diff)
Summary: _convert_method_name should take priority as conversionAlways use special methods for conversion/coercion if possible

comment:4 Changed 5 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Always use special methods for conversion/coercion if possibleNew Parent method _convert_method_map

comment:5 Changed 5 years ago by Jeroen Demeyer

Description: modified (diff)

comment:6 Changed 5 years ago by Jeroen Demeyer

Description: modified (diff)

comment:7 Changed 5 years ago by Jeroen Demeyer

Dependencies: #24372

comment:8 Changed 5 years ago by Jeroen Demeyer

Status: newneeds_review

comment:9 Changed 5 years ago by git

Commit: cf2f643c766b42094c2a403f9c4a27ae3f11d5c36f46f29822ef0cb9b8f81404a8162c925dbad0a7

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

375e40fMap._extra_slots(): do not pass dict
6f46f29New Parent method _convert_method_map

comment:10 Changed 5 years ago by Jeroen Demeyer

Status: needs_reviewneeds_work

comment:11 Changed 5 years ago by git

Commit: 6f46f29822ef0cb9b8f81404a8162c925dbad0a75c2f4f5c78c3b3a09451c601b64f4c536191b25b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5c2f4f5New Parent method _convert_method_map

comment:12 Changed 5 years ago by Jeroen Demeyer

Status: needs_workneeds_review

comment:13 Changed 5 years ago by Jeroen Demeyer

Cc: Vincent Delecroix Travis Scrimshaw added; Simon King removed
Dependencies: #24372

comment:14 Changed 5 years ago by Jeroen Demeyer

Ping? This is a dependency of #24371

comment:15 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

Incredibly nitpicking thing:

+from . coerce_maps cimport (NamedConvertMap, DefaultConvertMap,
+        DefaultConvertMap_unique, CallableConvertMap)

The space after the . looks strange, but I guess that is not a syntax error (a bit to my surprise). Feel free to set a positive review if you don't care or on my behalf if tweaked.

comment:16 Changed 5 years ago by git

Commit: 5c2f4f5c78c3b3a09451c601b64f4c536191b25b18d98778238982fd01f7cc9a1f027aff51460305

Branch pushed to git repo; I updated commit sha1. New commits:

18d9877Fix cimport

comment:17 Changed 5 years ago by Jeroen Demeyer

Status: needs_reviewpositive_review

Thanks!

comment:18 Changed 5 years ago by Volker Braun

Branch: u/jdemeyer/new_parent_method__convert_method_map18d98778238982fd01f7cc9a1f027aff51460305
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.