Opened 2 years ago

Closed 16 months ago

#24365 closed defect (fixed)

Nonnumeric integer expressions not handled by floor/ceil

Reported by: rws Owned by:
Priority: major Milestone: sage-8.2
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Bryan Gin-ge Chen
Report Upstream: N/A Work issues:
Branch: fcd36b8 (Commits) Commit: fcd36b863c24e69c0c7a83967428e43f99ade580
Dependencies: Stopgaps:

Description

In #22079 floor/ceil gets a new implementation. Symbolic arguments are not checked with is_integer however so we get

sage: var('x',domain='integer')
x
sage: floor(x)
floor(x)
sage: ceil(x)
ceil(x)

Inserting that check (if not is_numeric) would immediately simplify a class of expressions.

Change History (6)

comment:1 Changed 22 months ago by rws

  • Branch set to u/rws/nonnumeric_integer_expressions_not_handled_by_floor_ceil

comment:2 Changed 22 months ago by rws

  • Authors set to Ralf Stephan
  • Commit set to fcd36b863c24e69c0c7a83967428e43f99ade580
  • Status changed from new to needs_review

New commits:

fcd36b824365: handle nonnumeric integer expressions in floor/ceil

comment:3 Changed 21 months ago by rws

  • Status changed from needs_review to needs_work

Lots of doctest fails.

comment:4 Changed 21 months ago by rws

  • Status changed from needs_work to needs_review

Patchbot fails are all unrelated.

comment:5 Changed 17 months ago by gh-bryangingechen

  • Reviewers set to Bryan Gin-ge Chen
  • Status changed from needs_review to positive_review

This looks good to me.

comment:6 Changed 16 months ago by vbraun

  • Branch changed from u/rws/nonnumeric_integer_expressions_not_handled_by_floor_ceil to fcd36b863c24e69c0c7a83967428e43f99ade580
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.