Opened 4 years ago
Closed 4 years ago
#24353 closed enhancement (fixed)
Upgrade MPFR, MPC and MPFI
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage8.2 
Component:  packages: standard  Keywords:  
Cc:  zimmerma, fbissey  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Paul Zimmermann 
Report Upstream:  N/A  Work issues:  
Branch:  3c089ff (Commits, GitHub, GitLab)  Commit:  3c089ff224e709cc6ad647a123b8e06fe35d152a 
Dependencies:  Stopgaps: 
Change History (32)
comment:1 Changed 4 years ago by
 Cc fbissey added
comment:2 Changed 4 years ago by
 Branch set to u/jdemeyer/upgrade_to_mpfr_4_0_0
comment:3 Changed 4 years ago by
 Commit set to f93f4ac51cdd687efd359b5a28d84f691e5f63e7
comment:4 Changed 4 years ago by
 Description modified (diff)
 Summary changed from Upgrade to MPFR 4.0.0 to Upgrade to MPFR 4.0.0 and MPC 1.1.0
comment:5 Changed 4 years ago by
 Commit changed from f93f4ac51cdd687efd359b5a28d84f691e5f63e7 to 4db514de445746ebef06e07804653c4ae3f49867
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
4db514d  Upgrade to MPFR 4.0.0 and MPC 1.1.0

comment:6 Changed 4 years ago by
 Description modified (diff)
 Report Upstream changed from N/A to Reported upstream. No feedback yet.
 Summary changed from Upgrade to MPFR 4.0.0 and MPC 1.1.0 to Upgrade MPFR, MPC and MPFI
comment:7 Changed 4 years ago by
 Description modified (diff)
comment:8 Changed 4 years ago by
 Description modified (diff)
comment:9 followup: ↓ 10 Changed 4 years ago by
Unfortunately, it seems that MPFI is a dead project
Fabrice Rouillier tells me he is preparing the release of MPFI 1.5.2. Stay tuned!
comment:10 in reply to: ↑ 9 Changed 4 years ago by
Replying to zimmerma:
Fabrice Rouillier tells me he is preparing the release of MPFI 1.5.2. Stay tuned!
Is this personal communication or is this on some public channel? In the latter case, do you have a link?
comment:11 Changed 4 years ago by
Is this personal communication or is this on some public channel?
it is personal communication. If/when I have some information about a release candidate, I will post it here.
comment:12 Changed 4 years ago by
MPFI 1.5.2 is available from https://gforge.inria.fr/frs/?group_id=157
comment:13 Changed 4 years ago by
 Description modified (diff)
comment:14 Changed 4 years ago by
 Commit changed from 4db514de445746ebef06e07804653c4ae3f49867 to 16e31808d86c1259ff984f5ccbc92b407931c64e
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
16e3180  Upgrade MPFR, MPC and MPFI

comment:15 Changed 4 years ago by
 Commit changed from 16e31808d86c1259ff984f5ccbc92b407931c64e to 092ac74f8fe166c13d311e3243a6c33d7f99896a
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
092ac74  Upgrade MPFR, MPC and MPFI

comment:16 Changed 4 years ago by
There are a few obvious doctest failures in src/sage/rings/real_mpfr.pyx
. All should be easy to fix.
comment:17 Changed 4 years ago by
I am curious to know which failures you get.
comment:18 Changed 4 years ago by
 Commit changed from 092ac74f8fe166c13d311e3243a6c33d7f99896a to afc3b665878fcf151fa6ab46a6dd6bc97c73659b
Branch pushed to git repo; I updated commit sha1. New commits:
afc3b66  Minor fixes for MPFR4; support MPFR_RNDF

comment:19 Changed 4 years ago by
I added a few fixes in the last commit. With this, all tests pass. So, this ticket is technically needs_review, modulo the fact that there is no MPC release yet...
comment:20 followup: ↓ 22 Changed 4 years ago by
in the last commit:
faithful rounding (currently experimental; not supported for every operation)
"not supported for every operation" is not correct: it is supported, but not guaranteed correct for every operation.
Apart from that, I am ok with this commit.
We expect to release MPC 1.1 this week or next week.
comment:21 Changed 4 years ago by
 Commit changed from afc3b665878fcf151fa6ab46a6dd6bc97c73659b to 19646bee87f9ad06e3a2cd88d26eae63313f76ac
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
19646be  Minor fixes for MPFR4; support MPFR_RNDF

comment:22 in reply to: ↑ 20 Changed 4 years ago by
 Reviewers set to Paul Zimmermann
Replying to zimmerma:
"not supported for every operation" is not correct: it is supported, but not guaranteed correct for every operation.
Fixed.
Apart from that, I am ok with this commit.
OK, I'm adding you as reviewer.
comment:23 Changed 4 years ago by
MPC 1.1.0 is now available from https://ftp.gnu.org/gnu/mpc
comment:24 Changed 4 years ago by
 Description modified (diff)
comment:25 Changed 4 years ago by
 Commit changed from 19646bee87f9ad06e3a2cd88d26eae63313f76ac to 3c089ff224e709cc6ad647a123b8e06fe35d152a
comment:26 Changed 4 years ago by
 Status changed from new to needs_review
comment:27 Changed 4 years ago by
all tests pass on quasar (ubuntu x86_64)
comment:28 Changed 4 years ago by
 Report Upstream changed from Reported upstream. No feedback yet. to N/A
comment:29 Changed 4 years ago by
I did:
$ git co u/jdemeyer/upgrade_to_mpfr_4_0_0 $ git pull $ make build
and got an error:
ERROR [transferrun:135]: [Errno 404] Not Found: '//sagepad.org/spkg/upstream/mp fr/mpfr4.0.0.tar.bz2' Traceback (most recent call last): File "/tmp/sage/build/bin/sagedownloadfile", line 28, in <module> run_safe() File "/tmp/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 118, in run_safe run() File "/tmp/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 100, in run app.download_tarball(args.url_or_tarball, args.destination) File "/tmp/sage/build/bin/../sage_bootstrap/download/app.py", line 43, in down load_tarball tarball.download() File "/tmp/sage/build/bin/../sage_bootstrap/tarball.py", line 161, in download raise FileNotMirroredError('tarball does not exist on mirror network') sage_bootstrap.tarball.FileNotMirroredError: tarball does not exist on mirror ne twork ************************************************************************ Error downloading mpfr4.0.0.tar.bz2
comment:30 Changed 4 years ago by
You need to manually download the 3 tarballs mentioned on this ticket and put them in the upstream
directory in your Sage installation.
comment:31 Changed 4 years ago by
 Status changed from needs_review to positive_review
modulo the fact that the patchbot is happy, I give a positive review.
comment:32 Changed 4 years ago by
 Branch changed from u/jdemeyer/upgrade_to_mpfr_4_0_0 to 3c089ff224e709cc6ad647a123b8e06fe35d152a
 Resolution set to fixed
 Status changed from positive_review to closed
As reported on the MPFR mailing list by other people, this breaks MPC:
New commits:
Upgrade to MPFR 4.0.0