Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#24337 closed enhancement (fixed)

Remove the pickle jar

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-8.2
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: cf2b75e (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

As discussed in https://groups.google.com/d/msg/sage-devel/dZwxUCNEZWk/joIzOT0aBAAJ the pickle jar no longer serves the purpose that it was created for. So better remove it, as it is currently only an obstacle to development.

I am only removing the pickle jar itself and the related tests and documentation. The functions picklejar() and unpickle_all() which deal with the pickle jar are kept for now, in case that somebody wants to reboot (hopefully a better version of) the pickle jar.

Change History (6)

comment:1 Changed 5 years ago by Jeroen Demeyer

Branch: u/jdemeyer/remove_the_pickle_jar

comment:2 Changed 5 years ago by Jeroen Demeyer

Commit: cf2b75ea01727dd73dd5c47084065851d1e35d19
Description: modified (diff)
Status: newneeds_review

New commits:

cf2b75eRemove the pickle jar

comment:3 Changed 5 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

looks good to me

comment:4 Changed 5 years ago by Volker Braun

Branch: u/jdemeyer/remove_the_pickle_jarcf2b75ea01727dd73dd5c47084065851d1e35d19
Resolution: fixed
Status: positive_reviewclosed

comment:5 Changed 5 years ago by Erik Bray

Commit: cf2b75ea01727dd73dd5c47084065851d1e35d19

Now that this is gone, perhaps we could deprecate and/or remove the sage.misc.explain_pickle module. It's a nice utility for debugging pickling issues, but less relevant if we're no longer going to guarantee pickle preservation between versions.

comment:6 in reply to:  5 Changed 5 years ago by Jeroen Demeyer

Replying to embray:

Now that this is gone, perhaps we could deprecate and/or remove the sage.misc.explain_pickle module. It's a nice utility for debugging pickling issues, but less relevant if we're no longer going to guarantee pickle preservation between versions.

It's still relevant for debugging pickling issues within one Sage version I suppose.

Note: See TracTickets for help on using tickets.