Opened 4 years ago

Closed 4 years ago

#24328 closed enhancement (fixed)

New module to implement generic_power

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.2
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: fb9a0c2 (Commits, GitHub, GitLab) Commit: fb9a0c2e5a0dd88e82b7b6f1f56846deb696a56b
Dependencies: #24248 Stopgaps:

Status badges

Description (last modified by jdemeyer)

Move generic_power to a new Cython module sage.arith.power.

The old generic_power function in sage.structure.element is kept for now to avoid conflicts with other tickets, in particular #24247. It will be deprecated officially in #24256.

Change History (13)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/new_module_to_implement_generic_power

comment:2 Changed 4 years ago by git

  • Commit set to 28a42fd7d43fb66fcea499554b50655e1143b0fc

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

eeee3deMove long.pxd to arith
bb114c9Fake Integer interface
4d76bc1New functions integer_check_long() and integer_check_long_py()
28a42fdNew module to implement generic_power

comment:3 Changed 4 years ago by jdemeyer

  • Dependencies set to #24244

comment:4 Changed 4 years ago by jdemeyer

  • Dependencies changed from #24244 to #24248

comment:5 Changed 4 years ago by git

  • Commit changed from 28a42fd7d43fb66fcea499554b50655e1143b0fc to c0aca1c0ac92b95d790f39369a683269efbde530

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9c579c7Fix isinstance(x, int) calls in element.pyx
c0aca1cNew module to implement generic_power

comment:6 Changed 4 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from new to needs_review

comment:7 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:8 Changed 4 years ago by git

  • Commit changed from c0aca1c0ac92b95d790f39369a683269efbde530 to 59deaac33f8d5c1dfdc459ac313e7796abd84348

Branch pushed to git repo; I updated commit sha1. New commits:

59deaacVarious fixes

comment:9 Changed 4 years ago by git

  • Commit changed from 59deaac33f8d5c1dfdc459ac313e7796abd84348 to 1f431ba75f41771c49a25fd9a1df111d8ddde302

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1f431baVarious fixes

comment:10 Changed 4 years ago by git

  • Commit changed from 1f431ba75f41771c49a25fd9a1df111d8ddde302 to fb9a0c2e5a0dd88e82b7b6f1f56846deb696a56b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fb9a0c2Various fixes related to generic_power()

comment:11 Changed 4 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:12 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:13 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/new_module_to_implement_generic_power to fb9a0c2e5a0dd88e82b7b6f1f56846deb696a56b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.